Footer active filters #1118
Merged
Footer active filters #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update from nextstrain
…use it evaluates to an array. Did you mean checking 'Object.keys(this.props.activeFilters).length' instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
What is the goal of this pull request? What does this pull request change?
Condition 'Object.keys(this.props.activeFilters)' is always true because it evaluates to an array. Did you mean checking 'Object.keys(this.props.activeFilters).length' instead?
Related issue(s)
Fixes #
Related to #
I doubt that this code change has any effect on the page, other than a minimal performance change.
My goal is just a trivial 'clean-up': to correct the semantics of the code so it is more readable and does not throw a warning in Deepscan. Please ignore this PR, it is very low priority.
Testing
What steps should be taken to test the changes you've proposed?
If you added or changed behavior in the codebase, did you update the tests, or do you need help with this?
Sorry, I have not tested other than re-running Deepscan.
Thank you for contributing to Nextstrain!