[tree] escape key dismisses any info modal #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joverlee521
reviewed
Mar 16, 2022
src/components/tree/tree.js
Outdated
| @@ -41,6 +41,12 @@ class Tree extends React.Component { | |||
| root: [0, 0] | |||
| })); | |||
| }; | |||
| /* pressing the escape key should dismiss an info modal (if one exists) */ | |||
| this.handlekeydownEvent = (event) => { | |||
| if (event.keyCode===27 && this.state.selectedNode) { // key 27 is esc | |||
There was a problem hiding this comment.
FYI, keyCode has been marked as deprecated.
The alternative is to use key, which is equal to "Escape" or "Esc" in older browsers (see key values):
There was a problem hiding this comment.
Did not know, thanks Jover! Fixed & force-pushed.
joverlee521
reviewed
Mar 16, 2022
This implements what we think is an intuitive UI, and also helps with the bug described in #1243 where removing/disabling a strain-filter results in the tree visualisation falling out-of-sync with the modal. Note that `event.key` may not be implemented in all browsers, however this functionality is a nicety rather than a must-have, so this is tolerable. Thanks to @joverlee521 for suggesting to use this instead of `event.keyCode` during PR review. See #1479 for context. Closes #1479
jameshadfield
force-pushed
the
feat/escape-modal
branch
from
ed4bf13
to
25e5906
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements what we think is an intuitive UI, and also helps with
the bug described in #1243 where removing/disabling a strain-filter
results in the tree visualisation falling out-of-sync with the modal.
See #1479 for context.
Closes #1479