view: Respect HOST and PORT as defaults for --host and --port #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are widely-used conventions, and also Auspice recommends setting PORT when it runs into a "port in use" error trying to bind at start up. It's good to make that suggestion work thru `nextstrain view`. Reported by @corneliusroemer in Slack.¹ ¹ <https://bedfordlab.slack.com/archives/C01LCTT7JNN/p1694718932379359>
tsibley
force-pushed
the
trs/view/respect-HOST-and-PORT
branch
from
d20c31c
to
1519c9a
Compare
jameshadfield
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are widely-used conventions, and also Auspice recommends setting PORT when it runs into a "port in use" error trying to bind at start up. It's good to make that suggestion work thru
nextstrain view.Reported by @corneliusroemer in Slack.¹
¹ https://bedfordlab.slack.com/archives/C01LCTT7JNN/p1694718932379359
Checklist