Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word of caution for genome MT597439 #54

Closed
Rohit-Satyam opened this issue May 21, 2024 · 5 comments · Fixed by #55
Closed

Word of caution for genome MT597439 #54

Rohit-Satyam opened this issue May 21, 2024 · 5 comments · Fixed by #55
Assignees
Labels
bug Something isn't working

Comments

@Rohit-Satyam
Copy link

Though the header of the genome MT597439 says "Dengue virus type 2 isolate 43257 polyprotein (POLY) gene, partial cds; and sfRNA2 lncRNA gene, partial sequence", the serotype section of this genome tag it as

FEATURES Location/Qualifiers
source 1..10252
/organism="dengue virus type 2"
/mol_type="genomic RNA"
/serotype="4"
/isolate="43257"
/isolation_source="serum"
/host="Homo sapiens"
/db_xref="taxon:11060"
/country="South Korea"
/collection_date="2010"
/note="genotype: 2"

These people messed up while submission of this genome. In their Article here, they correctly assign it as DENV4/II (See Fig 1b, sample 43257 highlighted in yellow). I will request NCBI to correct this entry. But wanted to highlight it for the record.

@Rohit-Satyam Rohit-Satyam added the bug Something isn't working label May 21, 2024
@Rohit-Satyam
Copy link
Author

Kindly correct the ncbi_serotype section for this genome in https://data.nextstrain.org/files/workflows/dengue/metadata_all.tsv.zst

@j23414 j23414 self-assigned this May 21, 2024
@j23414 j23414 linked a pull request May 21, 2024 that will close this issue
1 task
@j23414
Copy link
Contributor

j23414 commented May 21, 2024

Thanks @Rohit-Satyam! I've PR'd a fix (#55) and the metadata should also reflect the fix now:

wget https://data.nextstrain.org/files/workflows/dengue/metadata_all.tsv.zst
zstd -d metadata_all.tsv.zst
grep "MT597439" metadata_all.tsv 

@j23414
Copy link
Contributor

j23414 commented May 21, 2024

Just a heads-up that some of the metadata columns just changed #41 (comment) and #51

  • ncbi_serotype -> serotype_ncbi
  • nextclade_subtype -> genotype_nextclade

@Rohit-Satyam
Copy link
Author

Just a heads-up that some of the metadata columns just changed #41 (comment) and #51

  • ncbi_serotype -> serotype_ncbi
  • nextclade_subtype -> genotype_nextclade

But this is yet to be updated in the metadata right? Coz I still see ncbi_serotype and nextclade_subtype

@j23414
Copy link
Contributor

j23414 commented May 22, 2024

Correct, it'll be updated within the next 24 hours, when the next ingest-to-phylogenetic github action runs.

It's set to run once a day (~10am Pacific Time), so should start running in ~40 mins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants