Consistent serotype-genotype column names and auspice color titles #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j23414
changed the title
genehack
approved these changes
May 21, 2024
Consistently names the serotype from Genbank fields as `serotype_genbank` in the metadata and `Serotype (Genbank metadata)` in the auspice tree.
Consistently names the genotype Nextclade assignment as `genotype_nextclade` in the metadata and `Dengue Genotype (Nextclade)` in the auspice tree.
During genome/dengue_all workflows, clade membership represents "Serotype (Nextstrain)"" While genome/dengue_denvX workflows, clade_membership represents the more detailed "Dengue Genotype (Nextstrain)"
For E gene builds that contain all serotypes, color by Serotype to match the full genome builds that contain all serotypes.
j23414
force-pushed
the
consistent-serotype-genotype-column-names
branch
from
ce361ce
to
f941515
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
For Dengue serotype, genotype, and the various methods we employ to derive them for a specific strain (NCBI, Nextclade, augur clades (Nextstrain)), this PR is an implementation of consistent metadata column names and auspice color titles following the plan in #41 (comment)
Related issue(s)
Checklist
Link to test builds from this branch:
or for a visual summary of the default color titles for the different trees: