Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dates not downloading properly #37

Closed
trvrb opened this issue Sep 4, 2016 · 3 comments
Closed

Dates not downloading properly #37

trvrb opened this issue Sep 4, 2016 · 3 comments
Labels
bug Something isn't working

Comments

@trvrb
Copy link
Member

trvrb commented Sep 4, 2016

I just tried to run python vdb/download.py -db vdb -v zika --fstem zika and I got:

>Zhejiang04|zika|KX117076|?|china|china|china|china|genbank|genome|Zhang et al
>1_0015_PF|zika|KX447511|?|oceania|french_polynesia|french_polynesia|french_polynesia|vipr|genome|Nougairede et al

All the collection_dates have been replaced with ?. Not exactly sure what's going on here. All the dates in the db itself look fine. Strangely python vdb/download.py -db vdb -v zika --fstem zika --ftype json is working just as it should.

@trvrb trvrb added the bug Something isn't working label Sep 4, 2016
chacalle added a commit that referenced this issue Sep 4, 2016
@chacalle
Copy link
Contributor

chacalle commented Sep 4, 2016

I think we've been using zika_download.py which is why we haven't seen this bug. So python vdb/zika_download.py -db vdb -v zika --fstem zika. Changed the default fasta fields in download.py to align with zika_download.py though.

@chacalle chacalle closed this as completed Sep 4, 2016
@trvrb
Copy link
Member Author

trvrb commented Sep 4, 2016

User error 😬. Sorry about that. Thanks for amending.

@chacalle
Copy link
Contributor

chacalle commented Sep 4, 2016

No problem. It might make sense to switch to just one download script that gets called and then the virus argument determines what methods need to be overwritten/added. This would reduce the confusion of specifying both zika_download and -v zika.

trvrb added a commit that referenced this issue Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants