Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error message when virus properties flag is missing #704

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

ivan-aksamentov
Copy link
Member

@ivan-aksamentov ivan-aksamentov commented Jan 25, 2022

Resolves: #703

Adds missing CLI args check for a situation where --input-dataset is not provided and neither the --input-virus-properties.

Now the error message reads as follows:

[ERROR] Nextclade: Error: Either --input-dataset or --input-virus-properties is required. Cannot proceed without virus properties. Note: the new required file virus_properties.json was introduced in version 1.10.0. You can obtain it from the latest Nextclade dataset. See nextclade dataset get --help and https://docs.nextstrain.org/projects/nextclade for more information

@vercel
Copy link

vercel bot commented Jan 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextstrain/nextclade/5wmJftY9oedwvJ383AbKPoQwnDS9
✅ Preview: https://nextclade-git-fix-virus-prop-json-improve-error-msg-nextstrain.vercel.app

Copy link
Member

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This shouldn't break anything so ready for patch release tomorrow once Richard has ok'ed it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants