Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize rather than filter to "complete" genomes #24

Closed
trvrb opened this issue Feb 20, 2019 · 1 comment
Closed

Prioritize rather than filter to "complete" genomes #24

trvrb opened this issue Feb 20, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@trvrb
Copy link
Member

trvrb commented Feb 20, 2019

Currently, besides reference genomes, select_strains.py is only passing through viruses that possess both HA and NA segments (due to our use of --segments ha na in the snakefile). For time pivots back about 3-6 months this is okay and there are usually enough strains with both HA and NA to fill sampling bins. However, some strains are just only getting HA sequenced. This was especially obvious looking just now where there are a number of H3s from January with just HA. These tend to be uploaded by groups that are not CCs.

I would propose to modify select_strains.py so that "complete" genome (as in possessing all entries in --segments) becomes another factor in priority rather than a hard constraint.

@trvrb trvrb added the enhancement New feature or request label Feb 20, 2019
@trvrb trvrb changed the title Prioritize rather than filter "complete" genomes Prioritize rather than filter to "complete" genomes Feb 20, 2019
@rneher
Copy link
Member

rneher commented Feb 21, 2019

I would add a --all-segments flag to force the hard filtering, otherwise prioritize.

rneher added a commit that referenced this issue May 26, 2019
… hard completeness constraint optional. fixes issue #24
@rneher rneher closed this as completed May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants