-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avatar): add RTL support to the avatar group component (#2497) #2498
Conversation
🦋 Changeset detectedLatest commit: 21d5b83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@mrbadri is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe recent patch introduces right-to-left (RTL) support for the AvatarGroup component within the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- .changeset/new-paws-remain.md (1 hunks)
- packages/core/theme/src/components/avatar.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/core/theme/src/components/avatar.ts
Additional comments: 1
.changeset/new-paws-remain.md (1)
- 1-5: The changeset document clearly outlines the patch update for the "@nextui-org/avatar" package, adding RTL support to the avatar group component. This is a concise and direct summary of the changes. However, it might be beneficial for users to know explicitly that this update does not introduce any breaking changes, as indicated in the PR description. Adding such a note could provide additional clarity and reassurance to users planning to update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! @mrbadri
Closes #2497
📝 Description
Add RTL support to the avatar group component.
⛳️ Current behavior (updates)
The avatar group component currently lacks support for right-to-left (RTL) direction.
🚀 New behavior
This PR addresses the RTL support issue in the breadcrumbs component, ensuring correct rendering in RTL environments.
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
Summary by CodeRabbit