Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avatar): add RTL support to the avatar group component (#2497) #2498

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

mrbadri
Copy link
Contributor

@mrbadri mrbadri commented Mar 10, 2024

Closes #2497

📝 Description

Add RTL support to the avatar group component.

⛳️ Current behavior (updates)

The avatar group component currently lacks support for right-to-left (RTL) direction.

🚀 New behavior

This PR addresses the RTL support issue in the breadcrumbs component, ensuring correct rendering in RTL environments.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Summary by CodeRabbit

  • New Features
    • Added right-to-left (RTL) support for the avatar group component, enhancing usability for RTL languages.

Copy link

changeset-bot bot commented Mar 10, 2024

🦋 Changeset detected

Latest commit: 21d5b83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@nextui-org/avatar Patch
@nextui-org/user Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2024 7:48pm

Copy link

vercel bot commented Mar 10, 2024

@mrbadri is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Mar 10, 2024

Walkthrough

The recent patch introduces right-to-left (RTL) support for the AvatarGroup component within the @nextui-org/avatar package. This enhancement aims to correct alignment and display issues encountered in RTL layouts, ensuring a seamless integration of the component in environments that utilize RTL languages, thereby improving usability and visual presentation across diverse locales.

Changes

File(s) Change Summary
.changeset/new-paws-remain.md Introduced a patch for RTL support in the AvatarGroup component.
packages/.../theme/src/components/avatar.ts Added rtl: prefixes to CSS classes to enable RTL translation behavior.

Assessment against linked issues

Objective Addressed Explanation
Bug Description and Expected Behavior (#2497)
Reproduction Steps and Environment (#2497) The changes do not include specific fixes for browser or OS.
Impact and Additional Context (#2497) It's unclear if all visual presentation issues are resolved without manual testing.

Poem

In the world of code, where left meets right,
A rabbit hopped, fixing a plight.
🥕🐇 Avatar friends, once lost in translation,
Now align with grace, in any nation.
With paws on keys, and eyes on screens,
We celebrate fixes, for machines and dreams.
Cheers to the devs, with their magic so bright,
Making the web a place, where all can unite.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 5a8768a and 21d5b83.
Files selected for processing (2)
  • .changeset/new-paws-remain.md (1 hunks)
  • packages/core/theme/src/components/avatar.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • packages/core/theme/src/components/avatar.ts
Additional comments: 1
.changeset/new-paws-remain.md (1)
  • 1-5: The changeset document clearly outlines the patch update for the "@nextui-org/avatar" package, adding RTL support to the avatar group component. This is a concise and direct summary of the changes. However, it might be beneficial for users to know explicitly that this update does not introduce any breaking changes, as indicated in the PR description. Adding such a note could provide additional clarity and reassurance to users planning to update.

Copy link
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @mrbadri

@jrgarciadev jrgarciadev merged commit 5d84634 into nextui-org:main Mar 16, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Lack of RTL Support in AvatarGroup
2 participants