Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove conflicting transition utilities #2677

Merged
merged 4 commits into from
Apr 14, 2024

Conversation

u3u
Copy link
Contributor

@u3u u3u commented Apr 10, 2024

Remove the default duplicate Transition utilities in TailwindCSS (they do not need to be redefined) to prevent users from customizing transition effects, such as duration-300 being overridden by the higher priority of the NextUI Plugin and not working.

Removing these redundant transition effects will not cause existing component effects to fail because TailwindCSS already includes them. Please feel free to check the preview documentation page. We only need to set DEFAULT_TRANSITION_DURATION to the DEFAULT key in order to modify the default transition time.

See: https://tailwindcss.com/docs/transition-property

Closes #1502

📝 Description

Add a brief description

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Summary by CodeRabbit

@u3u u3u requested a review from jrgarciadev as a code owner April 10, 2024 02:12
Copy link

changeset-bot bot commented Apr 10, 2024

🦋 Changeset detected

Latest commit: 42a1946

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nextui-org/theme Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2024 2:46am

Copy link

vercel bot commented Apr 10, 2024

@u3u is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Apr 10, 2024

Walkthrough

The update addresses a conflict between the @nextui-org/theme package and Tailwind CSS by adjusting transition utilities. By deactivating specific transition definitions in NextUI, it prevents them from conflicting with Tailwind's default transitions, ensuring a smoother integration experience for developers utilizing both frameworks.

Changes

File Path Change Summary
.changeset/rare-ants-ring.md Introduced a patch to resolve transition utility conflicts in @nextui-org/theme.
packages/core/theme/src/plugin.ts Added the default transition duration constant to the transitionDuration object.
packages/core/theme/src/utilities/transition.ts Commented out specific transition definitions for temporary removal or deactivation.

Assessment against linked issues

Objective Addressed Explanation
Prevent overriding of Tailwind's default transition by NextUI [#1502]
Ensure no duplicate transition definitions when using NextUI [#1502]
Maintain the ability to set custom transition effects in Tailwind [#1502]

Recent Review Details

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between b52abc9 and 42a1946.
Files selected for processing (1)
  • packages/core/theme/src/utilities/transition.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • packages/core/theme/src/utilities/transition.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

.changeset/rare-ants-ring.md Show resolved Hide resolved
Copy link
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @u3u

@jrgarciadev jrgarciadev merged commit 4dd2605 into nextui-org:main Apr 14, 2024
7 of 8 checks passed
@eBinaaOM
Copy link

@u3u @jrgarciadev Hello guys, I am having this trouble and I am a beginner , how can I use the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - The default transition of tailwindcss is overridden by the nextui plugin and has a higher priority.
4 participants