Reduce dependency on web audio #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pendragon-andyh
commented
Jul 28, 2020
pendragon-andyh
commented
Jul 28, 2020
Comment on lines
-1594
to
-1596
| if (Nexus.context.close) { | ||
| Nexus.context.close(); | ||
| } |
There was a problem hiding this comment.
Looking at the new Nexus.context causes an AudioContext to be created (see the new version of main.js).
pendragon-andyh
commented
Jul 28, 2020
| @@ -28,45 +29,21 @@ import { context } from '../main'; | |||
|
|
|||
| export default class Meter extends Interface { | |||
| constructor() { | |||
| let options = ['scale', 'value']; | |||
There was a problem hiding this comment.
scale and value don't seem to be used in Meter, Oscilloscope, and Spectrogram. Smells like copy-and-paste.
pendragon-andyh
commented
Jul 28, 2020
| @@ -142,46 +119,59 @@ export default class Meter extends Interface { | |||
| } | |||
|
|
|||
| /** | |||
| Equivalent to "patching in" an audio node to visualize. NOTE: You cannot connect audio nodes across two different audio contexts. NexusUI runs its audio analysis on its own audio context, Nexus.context. If the audio node you are visualizing is created on a different audio context, you will need to tell NexusUI to use that context instead: i.e. Nexus.context = YourAudioContextName. For example, in ToneJS projects, the line would be: Nexus.context = Tone.context . We recommend that you write that line of code only once at the beginning of your project. | |||
There was a problem hiding this comment.
The "NOTE" and the first line of the original example are no longer relevant.
pendragon-andyh
commented
Jul 28, 2020
Comment on lines
-158
to
+132
| if (channels) { | ||
| this.channels = channels; | ||
| } else if (node.channelCount) { | ||
| this.channels = node.channelCount; | ||
| } else { | ||
| this.channels = 2; | ||
|
|
||
| this.channels = channels || node.channelCount || 2; |
pendragon-andyh
commented
Jul 28, 2020
| } | ||
|
|
||
| click() { | ||
| this.active = !this.active; | ||
| this.active = !this.active && this.source; |
There was a problem hiding this comment.
Only toggle if the meter is connected to an AudioNode.
pendragon-andyh
commented
Jul 28, 2020
Comment on lines
+20
to
+37
| function unlockAudioContext(audioContext) { | ||
| const events = ['touchstart', 'touchend', 'mousedown', 'keydown']; | ||
|
|
||
| function unlock() { | ||
| events.forEach((eventName) => document.body.removeEventListener(eventName, unlock)); | ||
| if (audioContext.state === 'suspended') { | ||
| console.log('Audio context - unlocked ...'); | ||
| audioContext.resume(); | ||
| } | ||
| } | ||
|
|
||
| if (audioContext.state === 'suspended') { | ||
| console.log('Audio context - suspended until user interaction ...'); | ||
| events.forEach(eventName => { | ||
| document.body.addEventListener(eventName, unlock, false); | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
Not sure about this. Similar code seems to be used by multiple WebAudio projects (because AudioContext is supposed to initialize in a "suspended" state). Recent WebAudio issues indicate that this is implemented differently between the different browsers.
pendragon-andyh
commented
Jul 28, 2020
|
|
||
| /** | ||
| NexusUI => created as Nexus | ||
| */ | ||
|
|
||
| class NexusUI { | ||
|
|
||
| constructor(context) { |
There was a problem hiding this comment.
Not sure if reformatting was caused by editor or lint settings.
pendragon-andyh
commented
Jul 28, 2020
Comment on lines
+140
to
+141
| this._clock = new WAAClock(this.context); | ||
| this._clock.start(); |
There was a problem hiding this comment.
Clock is only created (and started) when it is specifically requested. I didn't create a setter.
lazzarello
added a commit
to lazzarello/scarlett-18i8-mixer
that referenced
this pull request
Aug 11, 2020
[Nexus UI Tutorial](https://nexus-js.github.io/ui/api/#intro), but for Vue.js with [async components](https://vuejs.org/v2/guide/components-dynamic-async.html#Async-Components) loading to enable the web audio context. The async stuff might not be needed when the [relevant PR is merged](nexus-js/ui#190).
tatecarson
approved these changes
Aug 29, 2020
tatecarson
approved these changes
Aug 29, 2020
tatecarson
added a commit
that referenced
this pull request
Aug 29, 2020
* updated discord message * feat: support for vertical orientation (#115) * fix: Nexus.tune.createScale() does not produce expected scale (#138) * fix: numberOfSliders does not change number of sliders for Multislider (#161) * feat: support for vertical orientation (#115) * feat: add padding to sequencer (#150) #178 * feat: add padding to sequencer (#150) #178 * removed commented out line * chore(release): 2.1.0 * chore(release): 2.1.1 * chore(release): 2.1.2 * add build * fix issue #161 * modify regex to support input of negative numbers to number component * update dist after regex change * chore(release): 2.1.3 * 🐛 Fix Nexus.Interval import regression * Fix Nexus.Interval import regression #184 * chore(release): 2.1.4 * Implement multi-touch piano * chore(release): 2.1.5 * Remove document.write * Rebuild dist files * Fix broken CSS in examples * Bump websocket-extensions from 0.1.3 to 0.1.4 (#185) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump standard-version from 7.1.0 to 8.0.1 (#187) Bumps [standard-version](https://github.com/conventional-changelog/standard-version) from 7.1.0 to 8.0.1. - [Release notes](https://github.com/conventional-changelog/standard-version/releases) - [Changelog](https://github.com/conventional-changelog/standard-version/blob/master/CHANGELOG.md) - [Commits](conventional-changelog/standard-version@v7.1.0...v8.0.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Reduce dependency on web audio (#190) * Only create AudioContext when necessary * Tweak npm version * Rebuild dist files * update documention cdn to use latest build * fixed mistake * fixed main and build * "chore(release): 2.1.6" * Update index.html trying to get it to rebuild Co-authored-by: Vladan Sarac <vladan.sarac.pv@gmail.com> Co-authored-by: jamesstaub <james.staub@gmail.com> Co-authored-by: Theis Bazin <theis.bazin@outlook.com> Co-authored-by: Andy Harman <andyh.at.pendragon@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andy Harman <pendragon-andyh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for:
. #145 (Initialize Without Web Audio Context)
. #147 (10% cpu usage by pulseaudio when a UI is loaded)
Notes:
. Need to regenerate api.json file.
. Need to update the NPM version numbers in the API index.html (or use @next?)
I have added pull-request comments so that you can more easily understand what I'm thinking.