-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI fails when making the CNAME file #1154
Comments
@prjemian Is CI still not building the documentation as it is done locally? |
In my local build ( (bluesky_2022_3) prjemian@zap:~/.../NeXus/definitions$ ls ./build/manual/build/html/CNAME
./build/manual/build/html/CNAME |
That was for the |
On main branch, with (bluesky_2022_3) prjemian@zap:~/.../NeXus/definitions$ ls ./build/manual/build/html/CNAME
ls: cannot access './build/manual/build/html/CNAME': No such file or directory |
The CNAME is created definitions/.github/workflows/publish-sphinx.yml Lines 79 to 81 in 1ac17ef
and then the definitions/.github/workflows/publish-sphinx.yml Lines 83 to 87 in 1ac17ef
This second step deletes the CNAME file, correct? |
Also note the default branch of sphinx-notes/pages Actions is |
I think we should add a job that builds the html, copies the CNAME file to the resulting folder and then |
Right. Our publishing steps might be too complicated for sphinx-notes/pages. |
Yes, so the point is that CNAME needs to be added to the result of an HTML build. In other words it needs to be copied afterward the sphinx HTML build. |
Of course we need to run the publishing CI to check which one works. I propose to merge #1158 first and wait for CI. |
Either that or suspend the rules, temporarily. This time, merge. |
Ok so #1158 doesn't work, probably because
But I'm not sure the build is actually done in there are the build is just copied there. |
After |
Maybe https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-html_extra_path is also an option. I'll investigate ... |
From the workflow log, steps 198-201
|
From raw logs:
So instead of echo manual.nexusformat.org > ./build/manual/build/html/CNAME then perhaps this will work: echo manual.nexusformat.org > ./CNAME |
html_extra_path works locally (PR #1159) so hopefully CI will like it as well. |
I see this line in the raw workflow logs:
|
Indeed. Seems ok now: https://github.com/nexusformat/definitions/runs/7138369879?check_suite_focus=true |
I will do the same on the |
https://github.com/nexusformat/definitions/runs/7137146695?check_suite_focus=true
The text was updated successfully, but these errors were encountered: