Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow add plugins to the Chart and Dataset components #1626

Closed
1 task
TahimiLeonBravo opened this issue Jun 12, 2020 · 0 comments · Fixed by #1638
Closed
1 task

feat: allow add plugins to the Chart and Dataset components #1626

TahimiLeonBravo opened this issue Jun 12, 2020 · 0 comments · Fixed by #1638
Assignees
@yvmunayev @rgah2107
Labels
3 coins enhancements

Comments

@TahimiLeonBravo
Copy link
Collaborator

TahimiLeonBravo commented Jun 12, 2020 •
edited by yvmunayev
Loading

Specs

import datalabels from 'chartjs-plugin-datalabels';

const plugins = { datalabels };

<Chart plugins={plugins} datalabels={ { color: '#AAA' } }>
    // customization at the dataset level
    <Dataset datalabels={ { color: '#CCC' } } /> 
</Charts>

Requirements

-[ ] Implement new feature

  • add tests
rgah2107 added a commit to rgah2107/react-rainbow that referenced this issue Jun 17, 2020
@rgah2107
feat: allow add plugins to the Chart and Dataset components
a7845c6 
fix: nexxtway#1626
@rgah2107 rgah2107 mentioned this issue Jun 17, 2020
Merged
1 task
maxxgreene pushed a commit that referenced this issue Jul 11, 2020
@rgah2107
feat: allow add plugins to the Chart and Dataset components (#1638)
58b660c 
* feat: allow add plugins to the Chart and Dataset components

fix: #1626

* fix: modify component according to the last comments

* fix: modify solution to unregister global plugins

* fix: modify test

* fix: modify component according to the established api

* fix: improve helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yvmunayev yvmunayev

@rgah2107 rgah2107

Labels
3 coins enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow add plugins to the Chart and Dataset components rgah2107/react-rainbow
3 participants
@yvmunayev @TahimiLeonBravo @rgah2107