Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add full value to the size prop on the drawer #1890

Merged
merged 3 commits into from
Oct 7, 2020
Merged

feat: add full value to the size prop on the drawer #1890

merged 3 commits into from
Oct 7, 2020

Conversation

amontalvof
Copy link
Collaborator

fix: #1878

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Oct 6, 2020 •
edited
Loading

Features

  • add full value to the size prop on the drawer (7a94d40)

Documentation

  • add example with full size (f3e54a5)

Contributors

@amontalvof, @TahimiLeonBravo

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codeclimate
Copy link

codeclimate bot commented Oct 7, 2020

Code Climate has analyzed commit a7e8b4c and detected 0 issues on this pull request.

View more on Code Climate.

@TahimiLeonBravo TahimiLeonBravo merged commit 31dc2de into master Oct 7, 2020
@TahimiLeonBravo TahimiLeonBravo deleted the add-full-to-the-size-prop-on-the-drawer branch October 7, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TahimiLeonBravo TahimiLeonBravo TahimiLeonBravo approved these changes

@LeandroTorresSicilia LeandroTorresSicilia LeandroTorresSicilia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add the "full" value to the size prop on the Drawer component
3 participants
@amontalvof @LeandroTorresSicilia @TahimiLeonBravo