feat: add input prop valueAlignment and deprecate isCentered #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features
Bug FixesContributorsyvmunayev, LeandroTorresSicilia Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
…precate-is-centered
|
Visit the preview URL for this PR (updated for commit b654673): https://react-rainbow--pr2453-feat-add-input-prop-xczdc1os.web.app (expires Sat, 08 Oct 2022 18:38:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
| } = this.props; | ||
| const isReadOnly = !!(!disabled && readOnly); | ||
| const isPassword = type === 'password'; | ||
| const alignment = isCentered ? 'center' : valueAlignment; |
There was a problem hiding this comment.
here you are giving priority, to isCentered but since we will deprecate it, we should do the inverse, then let's give priority to the valueAlignment over the isCentered
| @@ -62,7 +62,8 @@ export default class Input extends Component { | |||
|
|
|||
| renderInput() { | |||
| const { props } = this; | |||
| const { readOnly } = props; | |||
| const { readOnly, isCentered, valueAlignment } = props; | |||
| const alignment = isCentered ? 'center' : valueAlignment; | |||
…ntered' of https://github.com/nexxtway/react-rainbow into feat-add-input-prop-value-alignment-and-deprecate-is-centered
|
Code Climate has analyzed commit b654673 and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
LeandroTorresSicilia
approved these changes
Oct 2, 2022
LeandroTorresSicilia
deleted the
feat-add-input-prop-value-alignment-and-deprecate-is-centered
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2452
Changes proposed in this PR:
feat: add input prop valueAlignment and deprecate isCentered
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow