feat: add border radius to radio button group #2503
Conversation
Features
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
|
Adrian Estevez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Visit the preview URL for this PR (updated for commit 3ea789d): https://react-rainbow--pr2503-add-border-radius-to-8ld0gh5v.web.app (expires Fri, 04 Nov 2022 16:01:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2de6d670498a0a515484c5637b13d0215372df83 |
| { value: 'on', label: 'On' }, | ||
| ]; | ||
|
|
||
| class BorderRadiusRadioButtonGroup extends React.Component { |
There was a problem hiding this comment.
let's use functional components with hooks
| } | ||
|
|
||
| handleOnChange(event) { | ||
| return this.setState({ value: event.target.value }); |
There was a problem hiding this comment.
here we need different states for each RadioButtonGroup in order to not have that one controls all others
… border radius with different states
adrianestevez1
force-pushed
the
add-border-radius-to-radio-button-group
branch
from
19a5dd0
to
e4355a1
Compare
| /> | ||
| <RadioButtonGroup | ||
| label="Border Radius Rounded" | ||
| id="radio-button-group-component-1" |
There was a problem hiding this comment.
id here is not needed but if you will use id then they must be unique in all the page
|
Code Climate has analyzed commit 3ea789d and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
LeandroTorresSicilia
deleted the
add-border-radius-to-radio-button-group
branch
fix: #2495
Changes proposed in this PR:
-Add border radius to radio button group
@nexxtway/react-rainbow