Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add borderRadius prop to ButtonGroupPicker component #2508

Merged
merged 6 commits into from
Nov 2, 2022
Merged

feat: add borderRadius prop to ButtonGroupPicker component #2508

merged 6 commits into from
Nov 2, 2022

Conversation

adrianestevez1
Copy link
Contributor

fix: #2497

Changes proposed in this PR:

-add borderRadius prop to ButtonGroupPicker component

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Oct 27, 2022 •
edited
Loading

Features

  • add borderRadius prop to ButtonGroupPicker component (b5e819f)
  • add borderRadius prop to ButtonGroupPicker component (d27a409)
  • add borderRadius prop to ButtonGroupPicker component (4a6ede5)

Contributors

LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2022 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ LeandroTorresSicilia
❌ Adrian Estevez

Adrian Estevez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

github-actions bot commented Oct 27, 2022 •
edited
Loading

Visit the preview URL for this PR (updated for commit 8571836):

https://react-rainbow--pr2508-add-border-radius-to-7r6nb4s3.web.app

(expires Wed, 09 Nov 2022 05:13:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2de6d670498a0a515484c5637b13d0215372df83

LeandroTorresSicilia
LeandroTorresSicilia reviewed Oct 28, 2022
View reviewed changes
src/components/ButtonGroupPicker/readme.md Outdated
this.handleOnChange1 = this.handleOnChange1.bind(this);
this.handleOnChange2 = this.handleOnChange2.bind(this);
this.handleOnChange3 = this.handleOnChange3.bind(this);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let use functional components for all new examples

@codeclimate
Copy link

codeclimate bot commented Nov 2, 2022

Code Climate has analyzed commit 8571836 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 1

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 98bb8cf into master Nov 2, 2022
@LeandroTorresSicilia LeandroTorresSicilia deleted the add-border-radius-to-button-group-picker branch November 2, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeandroTorresSicilia LeandroTorresSicilia LeandroTorresSicilia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add borderRadius prop to ButtonGroupPicker component
3 participants
@adrianestevez1 @CLAassistant @LeandroTorresSicilia