Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add border radius to badge component #2532

Merged
merged 5 commits into from
Nov 19, 2022

Conversation

adrianestevez1
Copy link
Contributor

fix: #2500

Changes proposed in this PR:

-add border radius to badge component

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Nov 5, 2022

Features

  • add borderRadius prop to Badge component (1fff360)
  • add borderRadius prop to Badge component (05fcd81)

Bug Fixes

  • fix: add border radius to badge component (f6a4050)
  • update borderRadius type values (8a2abc3)

Contributors

LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@CLAassistant
Copy link

CLAassistant commented Nov 5, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ LeandroTorresSicilia
❌ Adrian Estevez


Adrian Estevez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -7,7 +7,7 @@ import Content from './content';
* Badges are labels that hold small amounts of information.
*/
export default function Badge(props) {
const { className, style, label, title, children, variant, size } = props;
const { className, style, label, title, children, variant, size, borderRadius } = props;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 11 locations. Consider refactoring.

@github-actions
Copy link

github-actions bot commented Nov 5, 2022

Visit the preview URL for this PR (updated for commit fc0b74f):

https://react-rainbow--pr2532-add-border-radius-to-csrlwpm8.web.app

(expires Sat, 26 Nov 2022 23:37:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2de6d670498a0a515484c5637b13d0215372df83

@LeandroTorresSicilia
Copy link
Member

@adrianestevez1 let's add types to index.d.ts also for the chip component

@codeclimate
Copy link

codeclimate bot commented Nov 19, 2022

Code Climate has analyzed commit fc0b74f and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 3

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit ab7dffc into master Nov 19, 2022
@LeandroTorresSicilia LeandroTorresSicilia deleted the add-border-radius-to-badge-component branch November 19, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add borderRadius prop to Badge component
3 participants