-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add border radius to badge component #2532
fix: add border radius to badge component #2532
Conversation
Features
Bug FixesContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
Adrian Estevez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@@ -7,7 +7,7 @@ import Content from './content'; | |||
* Badges are labels that hold small amounts of information. | |||
*/ | |||
export default function Badge(props) { | |||
const { className, style, label, title, children, variant, size } = props; | |||
const { className, style, label, title, children, variant, size, borderRadius } = props; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 11 locations. Consider refactoring.
Visit the preview URL for this PR (updated for commit fc0b74f): https://react-rainbow--pr2532-add-border-radius-to-csrlwpm8.web.app (expires Sat, 26 Nov 2022 23:37:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2de6d670498a0a515484c5637b13d0215372df83 |
@adrianestevez1 let's add types to index.d.ts also for the chip component |
Code Climate has analyzed commit fc0b74f and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
fix: #2500
Changes proposed in this PR:
-add border radius to badge component
@nexxtway/react-rainbow