Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: carousel card component using set timeout on react18 #2534

Merged
merged 13 commits into from
Dec 8, 2022
Merged

fix: carousel card component using set timeout on react18 #2534

merged 13 commits into from
Dec 8, 2022

Conversation

yvmunayev
Copy link
Contributor

fix: #2533

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Nov 12, 2022 •
edited

Bug Fixes

  • accordion component using setTimeout on componentDidMount in react 18 (baeea01)
  • accordion component using setTimeout in react 18 (fba2818)
  • refactor indicators component (800f330)
  • change useChildrenRegisterRef for useChildrenRegister hook (cca6f7d)

Features

Tests

  • refactor unit test using @testing-library/react (a29ed63)

Chore

Contributors

yvmunayev, LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@github-actions
Copy link

github-actions bot commented Nov 12, 2022 •
edited

Visit the preview URL for this PR (updated for commit e585fcf):

https://react-rainbow--pr2534-fix-carousel-card-co-sirhrjal.web.app

(expires Mon, 12 Dec 2022 23:06:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2de6d670498a0a515484c5637b13d0215372df83

@LeandroTorresSicilia
Copy link
Member

@yvmunayev there are two integration tests failing

Screen Shot 2022-12-03 at 2 13 09 PM

LeandroTorresSicilia
LeandroTorresSicilia reviewed Dec 3, 2022
View reviewed changes
src/libs/hooks/usePrevious.js Outdated
const ref = useRef();
useEffect(() => {
ref.current = value;
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here you should use an array of dependencies with value

codeclimate[bot]
codeclimate bot reviewed Dec 5, 2022
View reviewed changes
src/components/CarouselCard/index.js
this.startAnimation();
}
}
const CarouselCard = props => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function CarouselCard has 74 lines of code (exceeds 25 allowed). Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Dec 5, 2022

Code Climate has analyzed commit e585fcf and detected 17 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 6
Duplication 11

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit f829ab2 into master Dec 8, 2022
@LeandroTorresSicilia LeandroTorresSicilia deleted the fix-carousel-card-component-using-set-timeout-on-react18 branch December 8, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate CodeClimate codeclimate left review comments

@LeandroTorresSicilia LeandroTorresSicilia LeandroTorresSicilia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: carousel card component using set timeout on react18
2 participants
@yvmunayev @LeandroTorresSicilia