Implement library headers #449
Conversation
| @@ -0,0 +1,73 @@ | |||
| .react-rainbow-selector { | |||
| border-radius: 22px; | |||
| background-color: #fff; | |||
There was a problem hiding this comment.
change to background-color: transparent
| box-shadow: 0 2px 4px 0 #e3e5ed; | ||
| border: #e3e5ed 1px solid; | ||
| z-index: 100; | ||
| /*position: fixed;*/ |
There was a problem hiding this comment.
remove this comment
| <ButtonIcon icon={<RightArrow />} size="small" onClick={this.handleArrowCLick} /> | ||
| </div> | ||
| <RenderIf isTrue={isOpen}> | ||
| <div className="react-rainbow-selector_divider" /> |
There was a problem hiding this comment.
use our MenuDivider component
|
|
|
this is a styleguide component, then it must be inside library/styleguideComponents |
| @@ -0,0 +1,164 @@ | |||
| /* eslint-disable no-script-url */ | |||
There was a problem hiding this comment.
I think you should try to use our ButtonMenu for this or at least our internal PrimitiveMenu component.
Remember that you can pass a component in the MenuItem label prop.
This would simplify the component dramatically because all this logic is already in PrimitiveMenu.
| export default function RightArrow({ className, style }) { | ||
| const getArrowClassName = () => classnames('rainbow-accordion-section_right-icon', className); | ||
|
|
||
| return ( |
There was a problem hiding this comment.
why not make the arrow animated?
| <img src={rainbowLogo} alt="react-rainbow" /> | ||
| <div className="react-rainbow-selector_item-text"> | ||
| <span className="react-rainbow-selector_item-text_header">react-rainbow components</span> | ||
| <span className="react-rainbow-selector_item-text_subheader">version 0.8.20</span> |
There was a problem hiding this comment.
Each library has the load the version dynamically. It can't be passed manually.
| <MenuDivider className="react-rainbow-selector_divider" /> | ||
| <li> | ||
| <a | ||
| href="javascript:void(0);" |
There was a problem hiding this comment.
it should navigate to the prismic library
fixes #373