feat: added table sorting #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
follow the sorting styles when active and when hover like the design |
Pull Request Test Coverage Report for Build 1218
💛 - Coveralls |
… key to up performance
…act-rainbow into implement-table-sorting
| return ( | ||
| <Header | ||
| key={uniqueId('header')} | ||
| key={`header-${index}`} |
There was a problem hiding this comment.
put this in a variable:
const key = `header-${index}`;
also in this way you can remove the eslint exception a the top of the file
| */ | ||
| sortDirection: PropTypes.oneOf(['asc', 'desc']), | ||
| /** Action triggered when a column header is clicked */ |
There was a problem hiding this comment.
Action triggered when a column is sorted. Receive the event object, field and sortDirection.
| } | ||
| } else { | ||
| newSortDirection = 'asc'; | ||
| } |
There was a problem hiding this comment.
when implement inside Table remove this logic here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #453