Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to skip cluster sets #161

Merged
merged 7 commits into from
Apr 4, 2022
Merged

add option to skip cluster sets #161

merged 7 commits into from
Apr 4, 2022

Conversation

ggabernet
Copy link
Member

  • Added option to skip cluster sets process when processing data with UMI barcodes

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/airrflow branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Apr 3, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 9b4007e

+| ✅ 144 tests passed       |+
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: lib/WorkflowAirrflow.groovy
  • pipeline_todos - TODO string in test_reveal_no_cc.config: Specify the paths to your test data on nf-core/test-datasets
  • pipeline_todos - TODO string in test_reveal_no_cc.config: Give any required params for the test so that command line flags are not needed
  • schema_description - No description provided in schema for parameter: singlecell

✅ Tests passed:

Run details

  • nf-core/tools version 2.3.2
  • Run at 2022-04-03 13:38:08

FriederikeHanssen
FriederikeHanssen approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ggabernet
Copy link
Member Author

Thanks for the review @FriederikeHanssen !

@ggabernet ggabernet merged commit 6d47a97 into nf-core:dev Apr 4, 2022
@ggabernet ggabernet deleted the clustersets branch October 1, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggabernet @FriederikeHanssen