Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional contact fields #580

Open
edmundmiller opened this issue Oct 30, 2023 · 4 comments
Open

Add additional contact fields #580

edmundmiller opened this issue Oct 30, 2023 · 4 comments
Assignees

Comments

@edmundmiller
Copy link
Contributor

edmundmiller commented Oct 30, 2023

We might also move from:

-    config_profile_contact = 'Denis O\'Meally (@drejom) or HPRCC Helpdesk (HPRCC_Help@coh.org)'
+    config_profile_contact = 'Denis O\'Meally'
+    config_profile_contact_github = '@drejom'
+    config_profile_contact_email = "HPRCC_Help@coh.org"

Originally posted by @emiller88 in #577 (comment)

Basically some modules have all of the info, some modules don't. It's fine if they don't want to include an email for example. The real problem is they're not in a consistant format.

So we also need to go through and clean up the CODEOWNERS errors.

@edmundmiller edmundmiller self-assigned this Feb 16, 2024
edmundmiller added a commit to ahepperla/configs that referenced this issue Feb 23, 2024
@ewels
Copy link
Member

ewels commented Feb 27, 2024

Agree that this would be good. Originally this was not used for anything except printing to the pipeline stdout for Human eyes to read. But if we're using it programmatically in places then we should split it up 👍🏻

Downside is more params proliferation in every pipeline. But hopefully not too bad, and should be entirely managed through a (hopefully fairly clean) template update & sync.

@maxulysse
Copy link
Member

Why not something like config_profile_contact_it_email as well to get the email of the IT department?

@edmundmiller
Copy link
Contributor Author

I feel like that can be in the markdown in the docs.

@jfy133
Copy link
Member

jfy133 commented May 15, 2024

Why not something like config_profile_contact_it_email as well to get the email of the IT department?

they might not like being spammed about stuff they don't know about 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants