Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowners generation #577

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Add codeowners generation #577

merged 3 commits into from
Oct 30, 2023

Conversation

edmundmiller
Copy link
Contributor

Proposing we use this, and then set up review reminders in Slack, so when a PR goes stale(for say 3 days?) it'll then request maintainers on it. We could also flip on the load balancing on, and randomly assign a maintainer to do the initial review for new profiles that don't have a CODEOWNER.

Right now I get an @ every PR, which is just noisy. I'd rather know that I really am needed to review something.

This /should/ pick up all the configs and md files
@edmundmiller edmundmiller requested review from jfy133 and a team October 24, 2023 01:49
@edmundmiller edmundmiller self-assigned this Oct 24, 2023
@edmundmiller
Copy link
Contributor Author

We might also move from:

-    config_profile_contact = 'Denis O\'Meally (@drejom) or HPRCC Helpdesk (HPRCC_Help@coh.org)'
+    config_profile_contact = 'Denis O\'Meally'
+    config_profile_contact_github = '@drejom'
+    config_profile_contact_email = "HPRCC_Help@coh.org"

@@ -19,7 +18,7 @@ Steps for adding a new config profile:
- [ ] Add your profile name to the `profile:` scope in `.github/workflows/main.yml`

<!--
If you require/still waiting for a review, please feel free to request from @nf-core/maintainers
If you require/still waiting for a review, please feel free to request a review from @nf-core/maintainers
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this will still @ or not, we'll find out 🙃

.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! GitHub is complaining about many syntax errors in the file, but I like the concept!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see lots of errors on this file:

    Unknown owner on line 1: make sure @lecorguille exists and has write access to the repository

    **abims** @lecorguille

    Unknown owner on line 2: make sure @kalayaneech exists and has write access to the repository

    **adcra** @kalayaneech

    Unknown owner on line 3: make sure @osteobjorn exists and has write access to the repository

    **alice** @osteobjorn

    Invalid owner on line 4:

    **apollo** @coh.org

    Invalid owner on line 13:

    **biowulf** @hpc.nih.gov'

    Invalid owner on line 14:

    **cambridge** @cam.ac.uk

    Unknown owner on line 18: make sure @rajewski exists and has write access to the repository

    **cedars** @rajewski

    Invalid owner on line 22:

    **cheaha** @uab.edu

    Invalid owner on line 29:

    **dkfz** @dkfz-heidelberg.de'

    Unknown owner on line 30: make sure @marcel-keller exists and has write access to the repository

    **ebc** @marcel-keller

    Unknown owner on line 31: make sure @saulpierotti-ebi exists and has write access to the repository

    **ebi_codon** @saulpierotti-ebi

    Unknown owner on line 32: make sure @saulpierotti-ebi exists and has write access to the repository

    **ebi_codon_slurm** @saulpierotti-ebi

    Invalid owner on line 35:

    **ethz_euler** @hest.ethz.ch

    Invalid owner on line 37:

    **fgcz** @fgcz.ethz.ch"

    Invalid owner on line 38:

    **fub_curta** @zedat.fu-berlin.de'

    Invalid owner on line 39:

    **genotoul** @inra.fr'

    Unknown owner on line 40: make sure @abretaud exists and has write access to the repository

    **genouest** @abretaud

    Unknown owner on line 41: make sure @andreas-wilm exists and has write access to the repository

    **gis** @andreas-wilm

    Invalid owner on line 43:

    **googlebatch** @hnawar'

    Invalid owner on line 44:

    **googlels** @hnawar'

    Invalid owner on line 45:

    **hasta** config_profile_contact = 'Clinical Genomics, Stockholm'

    Invalid owner on line 49:

    **ifb_core** config_profile_contact = 'https://community.france-bioinformatique.fr'

    Invalid owner on line 50:

    **imperial** @imperial.ac.uk

    Invalid owner on line 51:

    **incliva** @incliva.es'

    Invalid owner on line 52:

    **ipop_up** @parisepigenetics.com'

    Invalid owner on line 53:

    **janelia** @janelia.hhmi.org

    Unknown owner on line 54: make sure @flynnb exists and has write access to the repository

    **jax** @flynnb

    Invalid owner on line 55:

    **ku_sund_dangpu** @sund.ku.dk>'

    Invalid owner on line 56:

    **leicester** @cam.ac.uk'

    Unknown owner on line 58: make sure @pierrespc exists and has write access to the repository

    **maestro** @pierrespc

    Invalid owner on line 59:

    **mana** config_profile_contact = 'Cedric Arisdakessian'

    Invalid owner on line 60:

    **marvin** @gmail.com (Pablo Carrion

    Invalid owner on line 61:

    **medair** @gu.se

    Unknown owner on line 65: make sure @mattdton exists and has write access to the repository

    **nci_gadi** @mattdton

    Unknown owner on line 66: make sure @NUjon exists and has write access to the repository

    **nu_genomics** @NUjon

    Invalid owner on line 67:

    **oist** @oist.jp>'

    Unknown owner on line 68: make sure @rplanel exists and has write access to the repository

    **pasteur** @rplanel

    Invalid owner on line 69:

    …pawsey_nimbus** @SarahBeecroft'

    Invalid owner on line 74:

    **uppmax** @lnu.se

    Invalid owner on line 98:

    **imperial** config_profile_contact = 'NA'

    Unknown owner on line 104: make sure @l-modolo exists and has write access to the repository

    **psmn** @l-modolo

    Invalid owner on line 105:

    **rosalind** config_profile_contact = 'Theo Portlock'

    Invalid owner on line 108:

    **sahmri** @sahmri.com

    Invalid owner on line 110:

    **scw** @bangor.ac.uk'

    Unknown owner on line 114: make sure @giusmar exists and has write access to the repository

    **tigem** @giusmar

    Unknown owner on line 115: make sure @sc13-bioinf exists and has write access to the repository

    **tubingen_apg** @sc13-bioinf

    Invalid owner on line 116:

    **tuos_stanage** @sheffield.ac.uk

    Unknown owner on line 117: make sure @brucemoran exists and has write access to the repository

    **ucd_sonic** @brucemoran

    Invalid owner on line 118:

    **ucl_myriad** @ucl.ac.uk

    Invalid owner on line 122:

    **unibe_ibu** @bioinformatics.unibe.ch"

    Invalid owner on line 123:

    **uod_hpc** @dundee.ac.uk

    Invalid owner on line 130:

    **vsc_kul_uhasselt** @kuleuven.be' @kuleuven.be' @kuleuven.be'

    Invalid owner on line 131:

    **vsc_ugent** @cmgg.be' @cmgg.be' @cmgg.be' @cmgg.be' @cmgg.be' @cmgg.be' @cmgg.be' @cmgg.be' @cmgg.be' @cmgg.be' @cmgg.be' @cmgg.be' @cmgg.be' @cmgg.be'

    Invalid owner on line 133:

    **wehi** @wehi.edu.au

    Invalid owner on line 134:

    **wustl_htcf** @wustl.edu>"

    Invalid owner on line 135:

    **xanadu** @uconn.edu'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it might work anyways?

The issue is we're not clear on whether we want a email or github user 😬

Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com>
@edmundmiller
Copy link
Contributor Author

Let's try it and we'll follow up with #580

@edmundmiller edmundmiller merged commit ac0a08b into master Oct 30, 2023
209 checks passed
@edmundmiller edmundmiller deleted the codeowners branch October 30, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants