Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nfcore tools update #342

Merged
merged 12 commits into from Feb 2, 2020
Merged

Nfcore tools update #342

merged 12 commits into from Feb 2, 2020

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 31, 2020

After some trial and error, this brings nf-core/eager to the nf-core tools linting 1.8 spec.

PR checklist

  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
@apeltzer apeltzer merged commit 0cbfb36 into nf-core:dev Feb 2, 2020
apeltzer added a commit that referenced this pull request Feb 3, 2020
[Merge #342 first] Performance improvement: zcat to cat
@jfy133 jfy133 deleted the nfcore-tools-update branch February 10, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants