Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indices fix #477

Closed
wants to merge 11 commits into from
Closed

Indices fix #477

wants to merge 11 commits into from

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jun 23, 2020

nf-core/eager pull request

Based off Bowtie2 (#476 ), to try and close #472 . @apeltzer how does this look?

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker --paired_end).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@jfy133 jfy133 marked this pull request as draft June 23, 2020 09:27
@jfy133 jfy133 linked an issue Jun 23, 2020 that may be closed by this pull request
FastA indexing + bwa indexing #472
Closed
@jfy133 jfy133 marked this pull request as ready for review June 23, 2020 20:28
@jfy133 jfy133 linked an issue Jun 30, 2020 that may be closed by this pull request
Some more AWS issues #473
Closed
@apeltzer
Copy link
Member

apeltzer commented Jul 8, 2020

Is this still current?

@jfy133
Copy link
Member Author

jfy133 commented Jul 8, 2020

This was meant to be for the Aws stuff iirc?

@apeltzer
Copy link
Member

I will close this, and start again from the current dev (easier as there were too many changes until now 😓 )

@apeltzer apeltzer closed this Jul 12, 2020
@apeltzer apeltzer deleted the indices-fix branch July 12, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some more AWS issues FastA indexing + bwa indexing
2 participants
@jfy133 @apeltzer