New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the non-free netMHC tool family #73
Conversation
7ba3511
to
7ef5b3e
Compare
396d9bf
to
f1137eb
Compare
This is ready for review from my end. It's worth noting that the added CI will fail when the PR comes from a fork, i.e. only nf-core team members who can open a branch here can also run the CI successfully. Thus I guess it should stay optional. Since we discussed the non-free integration on Slack, maybe @nf-core/core could also cross check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some minor things from my side. Thanks!
Let's wait for feedback from the nf-core core team regarding your question before merging.
Co-authored-by: Christopher Mohr <christopher.mohr@uni-tuebingen.de>
PR checklist
CHANGELOG.md
is updateddocs
is updatedAdditions
This patch adds support for the non-free 3rd party tools NetMHC, NetMHCpan, NetMHCII and NetMHCIIpan. Since the tools' licenses do not allow for redistribution of the software, the user has to provide the software tarball which can be obtained from the upstream website.
Changes
epaa.py
: Make tool name comparison case insensitive. Unfortunately, the method names aren't uniform w.r.t. upper / lower case letters among the netMHC family of tools.main.nf
: Convertparams.tools
to a groovy list before parsing. The previous.contains()
calls were applied on strings, which worked fine for the previously used tools, but since e.g.netmhc
is a substring ofnetmhcpan
it would clash with the newly added tools