Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch invalid input index def #79

Merged
merged 2 commits into from Aug 5, 2020
Merged

Patch invalid input index def #79

merged 2 commits into from Aug 5, 2020

Conversation

pditommaso
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/hlatyping branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/hlatyping/tree/master/.github/CONTRIBUTING.md

Description

This PR address the issue #68.

The main problem was the index was not properly declared in the remap_to_hla process inputs declared.

I guess this was not done because the input it's not just a single index file, but multiple ones. To make things worse the yara_mapper uses the ugly approach to take as input params not a fake path name and using it to resolve all the dependant files e.g. hla_reference_dna.rid.limits, hla_reference_dna.sa.ind, etc.

I've fixed introducing the following params:

  base_index_type = 'dna'
  base_index_path = "$baseDir/data/indices/yara" 
  base_index_name = "hla_reference_$params.base_index_type"
``  


This is also related to https #76 since the PR removes the `index` params .


Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - once Chris is happy, I'm too :-)

HLAtyping would really need some updated I fear, template bump(s), new release - something for the hackathon I guess

Copy link
Collaborator

@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @pditommaso !

@apeltzer I talked to @ggabernet and we think it would make more sense to do the template bump before merging. What do you think?

nextflow.config Show resolved Hide resolved
@apeltzer apeltzer changed the base branch from master to dev August 5, 2020 06:51
@christopher-mohr
Copy link
Collaborator

nf-core linting fails because params are not part of the schema yet. Can we still merge it? I will make a separate PR to complete the schema...

@apeltzer apeltzer merged commit 069b57c into nf-core:dev Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants