Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter the pipeline at step 3 (detect and remove chimeric reads) #10

Closed
reginabohnert opened this issue Nov 24, 2022 · 6 comments · Fixed by #32
Closed

Enter the pipeline at step 3 (detect and remove chimeric reads) #10

reginabohnert opened this issue Nov 24, 2022 · 6 comments · Fixed by #32
Labels
enhancement Improvement for existing functionality

Comments

@reginabohnert
Copy link

Description of feature

When already having CCS consensus reads cleaned from primer sequences and no raw subreads, it would be very helpful to have an option to enter the pipeline at step 3 (detect and remove chimeric reads).

@reginabohnert reginabohnert added the enhancement Improvement for existing functionality label Nov 24, 2022
@sguizard
Copy link
Collaborator

sguizard commented Dec 8, 2022

Hi @reginabohnert,

It's a good idea, it would avoid a lot of computation.
I also have in mind the possibility to enter at mapping step.
Adding this option imply to have an alternative input file format.
I need to check how it could be implemented in order to comply with the guidelines.
I'm pretty busy for a moment, but I'll try to have a look in the coming weeks.

@reginabohnert
Copy link
Author

Hi @sguizard,

Many thanks, it would be very helpful. Looking forward seeing it implemented!

@cazzlewazzle89
Copy link

Hi @sguizard
Just checking in to see whether you were able to implement this? It would be a very handy feature.
Thanks, Calum

@sguizard
Copy link
Collaborator

Hi @cazzlewazzle89,
I have been thinking about this feature since the announcement of the new Pacbio sequencers.
Since they will not produce the subreads and directly send the HiFi generated with deepconsensus, this pipeline will become obsolete at some point.
That why I'm thinking to forking it (tamannot?) and make more generic by chopping down the isoseq part.
The pipeline would take as input a fasta and an optional gff.
I also have to see if this new pipeline should (and is allowed to) seats on nf-core repo or I keep it personal.
Once I found a new contract, I'll work on this.

@vicenciooostra
Copy link

Hi @sguizard,
this sounds like a great feature; I'm in the same boat, have my HiFi reads and would like to enter the pipeline after the isoseq3 step. Do you think this will be implemented?
Best regards, Vicencio

@sguizard
Copy link
Collaborator

Implemented!

@sguizard sguizard mentioned this issue Aug 29, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants