Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.

Add 10x tgz input support with extracting aligned/unaligned reads #48

Closed
wants to merge 151 commits into from

Conversation

olgabot
Copy link
Collaborator

@olgabot olgabot commented Mar 20, 2020

Replaces #47

Many thanks to contributing to nf-core/kmer-similarity!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/kmer-similarity branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/kmer-similarity/tree/master/.github/CONTRIBUTING.md

@pranathivemuri
Copy link
Contributor

// gzipped files are 20 bytes when "empty" due to the header - on mac they were 58 bytes when I was testing? maybe there should be a better check for seeing if the gzipped file is empty than size?

@pranathivemuri
Copy link
Contributor

@olgabot
Copy link
Collaborator Author

olgabot commented Apr 14, 2020

// gzipped files are 20 bytes when "empty" due to the header - on mac they were 58 bytes when I was testing? maybe there should be a better check for seeing if the gzipped file is empty than size?

Oh hmm interesting. I was using the -profile docker setting so that's a really good catch for e.g. -profile conda on the local system.

@olgabot
Copy link
Collaborator Author

olgabot commented Apr 20, 2020

@pranathivemuri Is this something you could add? A check for empty gzipped files?

@pranathivemuri
Copy link
Contributor

we could check it inside the count_umis.py program if record_count == 0 in that fastq.gz file

    with screed.open(path) as f:
        record_count = 0
        for record in f:
            record_count += 1
    if record_count == 0:
           return 

@olgabot
Copy link
Collaborator Author

olgabot commented Apr 21, 2020

Closing in favor of #63

@olgabot olgabot closed this Apr 21, 2020
@ewels ewels deleted the olgabot/10x-tgz branch October 22, 2020 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants