Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAT is not included in the the BIN_SUMMARY #535

Closed
maxibor opened this issue Nov 3, 2023 · 1 comment · Fixed by #562
Closed

CAT is not included in the the BIN_SUMMARY #535

maxibor opened this issue Nov 3, 2023 · 1 comment · Fixed by #562
Assignees
Labels
enhancement New feature or request

Comments

@maxibor
Copy link
Member

maxibor commented Nov 3, 2023

Description of the bug

RIght now, only GTDB-Tk taxonomic classification is reported in the BIN_SUMMARY process.
But now that nf-core/mag can handle more than prokaryotic/archeal MAGs, it would be nice to have CAT also be included in the bin summary table, since it can classify also other clades (which GTDB-Tk can't).

Command used and terminal output

No response

Relevant files

No response

System information

No response

@maxibor maxibor added bug Something isn't working enhancement New feature or request labels Nov 3, 2023
@maxibor
Copy link
Member Author

maxibor commented Nov 21, 2023

Example cat_summary.tsv file:

# bin	classification	reason	lineage	lineage scores	full lineage names
MEGAHIT-CONCOCT-metagenomebis_10.fa	taxid assigned	based on 17/17 ORFs	1;131567;2;1783272;1239;186801;186802;31979;1485;1502	1.00;0.76;0.76;0.76;0.76;0.76;0.76;0.76;0.76;0.76	root (no rank): 1.00	cellular organisms (no rank): 0.76	Bacteria (superkingdom): 0.76	Terrabacteria group (clade): 0.76	Firmicutes (phylum): 0.76	Clostridia (class): 0.76	Clostridiales (order): 0.76	Clostridiaceae (family): 0.76	Clostridium (genus): 0.76	Clostridium perfringens (species): 0.76
MEGAHIT-CONCOCT-metagenomebis_100.fa	taxid assigned	based on 7/7 ORFs	1;131567;2;1783272;1239;186801;186802;31979;1485;1502	1.00;1.00;1.00;1.00;1.00;1.00;1.00;1.00;1.00;1.00	root (no rank): 1.00	cellular organisms (no rank): 1.00	Bacteria (superkingdom): 1.00	Terrabacteria group (clade): 1.00	Firmicutes (phylum): 1.00	Clostridia (class): 1.00	Clostridiales (order): 1.00	Clostridiaceae (family): 1.00	Clostridium (genus): 1.00	Clostridium perfringens (species): 1.00
MEGAHIT-CONCOCT-metagenomebis_101.fa	taxid assigned	based on 7/7 ORFs	1;131567;2;1783272;1239;186801;186802;31979;1485;1502	1.00;1.00;1.00;1.00;1.00;1.00;1.00;1.00;1.00;0.96	root (no rank): 1.00	cellular organisms (no rank): 1.00	Bacteria (superkingdom): 1.00	Terrabacteria group (clade): 1.00	Firmicutes (phylum): 1.00	Clostridia (class): 1.00	Clostridiales (order): 1.00	Clostridiaceae (family): 1.00	Clostridium (genus): 1.00	Clostridium perfringens (species): 0.96
MEGAHIT-CONCOCT-metagenomebis_102.fa	taxid assigned	based on 6/6 ORFs	1;131567;2;1783272;1239;186801;186802;31979;1485;1502	1.00;1.00;1.00;1.00;1.00;0.73;0.73;0.73;0.73;0.73	root (no rank): 1.00	cellular organisms (no rank): 1.00	Bacteria (superkingdom): 1.00	Terrabacteria group (clade): 1.00	Firmicutes (phylum): 1.00	Clostridia (class): 0.73	Clostridiales (order): 0.73	Clostridiaceae (family): 0.73	Clostridium (genus): 0.73	Clostridium perfringens (species): 0.73
MEGAHIT-CONCOCT-metagenomebis_103.fa	taxid assigned	based on 17/18 ORFs	1;131567;2;1783272;1239;186801;186802;31979;1485;1502	1.00;1.00;1.00;1.00;1.00;1.00;1.00;1.00;1.00;1.00	root (no rank): 1.00	cellular organisms (no rank): 1.00	Bacteria (superkingdom): 1.00	Terrabacteria group (clade): 1.00	Firmicutes (phylum): 1.00	Clostridia (class): 1.00	Clostridiales (order): 1.00	Clostridiaceae (family): 1.00	Clostridium (genus): 1.00	Clostridium perfringens (species): 1.00
MEGAHIT-CONCOCT-metagenomebis_104.fa	taxid assigned	based on 6/7 ORFs	1;131567;2;1783272;1239;186801;186802;31979;1485;1502	1.00;1.00;1.00;1.00;1.00;1.00;1.00;1.00;1.00;1.00	root (no rank): 1.00	cellular organisms (no rank): 1.00	Bacteria (superkingdom): 1.00	Terrabacteria group (clade): 1.00	Firmicutes (phylum): 1.00	Clostridia (class): 1.00	Clostridiales (order): 1.00	Clostridiaceae (family): 1.00	Clostridium (genus): 1.00	Clostridium perfringens (species): 1.00

@maxibor maxibor removed the bug Something isn't working label Nov 21, 2023
@maxibor maxibor self-assigned this Nov 29, 2023
@maxibor maxibor linked a pull request Jan 26, 2024 that will close this issue
3 tasks
@jfy133 jfy133 closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants