-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shinyngs/staticdifferential #2399
Shinyngs/staticdifferential #2399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly LGTM but needs to remove the presumeed meta
information from the module
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you've dropped the meta fields then LGTM
Thanks @jfy133 for review, hopefully I fully addressed your points in that final commit. I'll also look into submitting the analogous fix on deseq2/differential. |
Just a simple module wrapper for https://github.com/pinin4fjords/shinyngs/blob/develop/exec/differential_plots.R, useful for making differential plots in differential analysis workflows. Right now it's just making volcano plots, but will be extended in future.
Notes;
PR checklist
Closes #2398
versions.yml
file.label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware