Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shinyngs/app #2315

Merged
merged 32 commits into from
Oct 25, 2022
Merged

Shinyngs/app #2315

merged 32 commits into from
Oct 25, 2022

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Oct 17, 2022

Adds a module for creation of Shiny apps like this with shinyngs via a CLI script. Not all features are yet available via the CLI, but I'm working on it.

The CLI also allows triggering of a push of the app to shinyapps.io.

See also static plotting in #2364.

PR checklist

Closes #2190

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@pinin4fjords pinin4fjords marked this pull request as draft October 17, 2022 08:58
@pinin4fjords pinin4fjords added the WIP Work in progress label Oct 17, 2022
@pinin4fjords pinin4fjords changed the title [WIP] Shinyngs/app Shinyngs/app Oct 17, 2022
@pinin4fjords pinin4fjords linked an issue Oct 17, 2022 that may be closed by this pull request
4 tasks
@pinin4fjords pinin4fjords added Ready for Review and removed WIP Work in progress labels Oct 18, 2022
@pinin4fjords pinin4fjords requested a review from a team October 18, 2022 14:53
@pinin4fjords pinin4fjords marked this pull request as ready for review October 18, 2022 15:01
@pinin4fjords pinin4fjords added the new module Adding a new module label Oct 18, 2022
@pinin4fjords pinin4fjords marked this pull request as ready for review October 20, 2022 23:56
@pinin4fjords pinin4fjords requested a review from a team October 20, 2022 23:56
@pinin4fjords pinin4fjords mentioned this pull request Oct 21, 2022
14 tasks
Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes 🚀

modules/nf-core/shinyngs/app/main.nf Outdated Show resolved Hide resolved
modules/nf-core/shinyngs/app/meta.yml Show resolved Hide resolved
modules/nf-core/shinyngs/app/meta.yml Show resolved Hide resolved
Jonathan Manning and others added 4 commits October 24, 2022 19:30
@pinin4fjords
Copy link
Member Author

Thanks for review @nvnieuwk - think I've addressed the points

@pinin4fjords pinin4fjords merged commit 242a4ee into nf-core:master Oct 25, 2022
@pinin4fjords pinin4fjords deleted the shinyngs/app branch October 25, 2022 15:37
@pinin4fjords pinin4fjords mentioned this pull request Oct 26, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: shinyngs/app
2 participants