Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shinyngs/staticexploratory #2364

Merged
merged 15 commits into from
Oct 21, 2022

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Oct 20, 2022

Adds a module for producing a package of exploratory plots for matrix-derived data, calling functions from shinyngs. A wrapper around https://github.com/pinin4fjords/shinyngs/blob/develop/exec/exploratory_plots.R.

See also #2315

PR checklist

Closes #2193

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@pinin4fjords pinin4fjords added new module Adding a new module WIP Work in progress labels Oct 20, 2022
@pinin4fjords pinin4fjords marked this pull request as draft October 20, 2022 17:55
@pinin4fjords
Copy link
Member Author

@nf-core-bot fix linting

@pinin4fjords pinin4fjords requested a review from a team October 21, 2022 00:03
@pinin4fjords pinin4fjords added Ready for Review and removed WIP Work in progress labels Oct 21, 2022
@pinin4fjords pinin4fjords mentioned this pull request Oct 21, 2022
14 tasks
@pinin4fjords pinin4fjords marked this pull request as ready for review October 21, 2022 08:16
@matthdsm matthdsm merged commit bf69d2f into nf-core:master Oct 21, 2022
@pinin4fjords
Copy link
Member Author

Thanks for the quick review @matthdsm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: shinyngs/static_exploratory
3 participants