Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stubs for rnaseq subworkflows - part II #5913

Merged
merged 6 commits into from
Jul 3, 2024

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Jul 3, 2024

Continuing #5911 with:

  • Fix stub for modules:
    • kallisto/index
    • kallisto/quant
  • Add stub tests for subworkflows:
    • fastq_fastqc_umitools_fastp
    • fastq_fastqc_umitools_trimgalore
    • fastq_subsample_fq_salmon
    • quantify_pseudo_alignment

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@maxulysse maxulysse marked this pull request as ready for review July 3, 2024 14:02
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! 🚀

@maxulysse maxulysse enabled auto-merge July 3, 2024 14:32
@maxulysse maxulysse added this pull request to the merge queue Jul 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2024
@maxulysse maxulysse added this pull request to the merge queue Jul 3, 2024
Merged via the queue into nf-core:master with commit fbe341e Jul 3, 2024
35 checks passed
@maxulysse maxulysse deleted the stubs_rnaseq_iv branch July 3, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants