Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bbmap index #683

Merged
merged 5 commits into from
Sep 3, 2021
Merged

Bbmap index #683

merged 5 commits into from
Sep 3, 2021

Conversation

erikrikarddaniel
Copy link
Member

@erikrikarddaniel erikrikarddaniel commented Sep 1, 2021 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the <SOFTWARE>.version.txt file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd

Adds a module that creates a BBMap index.

I really don't need the meta map, but it didn't lint when I removed it.

jfy133
jfy133 requested changes Sep 2, 2021
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions but overal LGTM

modules/bbmap/index/main.nf Outdated Show resolved Hide resolved
modules/bbmap/index/main.nf Outdated Show resolved Hide resolved
jfy133
jfy133 approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once tests pass

@erikrikarddaniel erikrikarddaniel merged commit 0f59b07 into nf-core:master Sep 3, 2021
drpatelh added a commit that referenced this pull request Sep 15, 2021
@mahesh-panchal @abhi18av
@jfy133 @rpetit3 @grst @jianhong @jemten @maxulysse @heuermh @erikrikarddaniel @drpatelh
Chromap Module (#659)
58134cb 
* Initialise chromap module

* Revert "Initialise chromap module"

This reverts commit 47c67ae.

* Remake chromap base files with new layout

* Copy chromap

* Copy index

* Add compression

* Update padding

* Update container

* Update chromap input test data

* Add chromap chromap tests

* Add padding

* Update comment

* update yaml file

* Remove TODOs

* Add fasta input to yaml

* Update YAML

* Remove comment, update container

* Remove comments

* Import Chromap index

* Update test.yml

* Fix read input

* Update test.yml

* Add bcftools/concat module. (#641)

* draft for bcftools modules [ci skip]

* initial test for bcftools concat

* Update the params for testing

* fix tests

* Accomodate code review [ci skip]

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>

* Update the meta file and open PR for review

* Update the keyword

* Update the tags for module [ci skip[

* add threads

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>

* add module for dragonflye (#633)

* add module for dragonflye

* fix tests for dragonflye

* Update test.yml

* Update meta.yml

* Update main.nf

* Update main.nf

* Update modules/dragonflye/meta.yml

Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>

* update typos. change quote from ' to ". (#652)

* Add bcftools/norm module (#655)

* Initial draft [ci skip]

* trigger first test

* update output file path

* Tests passing

* finishing touches for meta.yml and update checksum

* tweak checksum

* add threads to the module

* skip version info for matching test md5sum [ci skip]

* Add ref fasta and finalize the module

Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>

* Expansionhunter (#666)


Please enter the commit message for your changes. Lines starting

* adds expansionhunter module

Co-authored-by: Maxime U. Garcia <maxime.garcia@scilifelab.se>

* Update test.yml (#668)

* Specify in guidelines one should split CPUs when module has n > 1 tool (#660)

* Specify more guidelines on input channels

* Linting

* Updates based on code review

* Update README.md

* Fix broken sentence

* Describe CPU splitting

* Update README.md

Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>

* More CPU examples

Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>

* Add dsh-bio export-segments module (#631)

Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>

* update: `BWA/ALN` (#653)

* Specify more guidelines on input channels

* Linting

* Updates based on code review

* Update README.md

* Fix broken sentence

* Remove reads from output channel following module guidelines. Should do a .join() based on $meta, to reassociate.

Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>

* Update seqwish reported version to match bioconda version. (#678)

* Bbmap index (#683)

BBMap index module

* Initialise chromap module

* Revert "Initialise chromap module"

This reverts commit 47c67ae.

* Remove unnecessary files

* Remove unnecessary files

* Update modules/chromap/index/main.nf

Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>

* Update modules/chromap/index/main.nf

Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>

* Update modules/chromap/chromap/main.nf

Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>

* Update tests/modules/chromap/chromap/main.nf

Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>

* Update tests/modules/chromap/chromap/main.nf

Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>

* Update tests/modules/chromap/chromap/main.nf

Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>

* Update modules/chromap/index/main.nf

Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>

* Remove pytest_software.yml

* Apply suggestions from code review

Co-authored-by: Abhinav Sharma <abhi18av@users.noreply.github.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: Robert A. Petit III <robbie.petit@gmail.com>
Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>
Co-authored-by: JIANHONG OU <jianhong@users.noreply.github.com>
Co-authored-by: Anders Jemt <jemten@users.noreply.github.com>
Co-authored-by: Maxime U. Garcia <maxime.garcia@scilifelab.se>
Co-authored-by: Michael L Heuer <heuermh@acm.org>
Co-authored-by: Daniel Lundin <daniel.lundin@lnu.se>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
abhi18av added a commit to abhi18av/modules that referenced this pull request Sep 15, 2021
@mahesh-panchal @abhi18av
@jfy133 @rpetit3 @grst @jianhong @jemten @maxulysse @heuermh @erikrikarddaniel @drpatelh
Chromap Module (nf-core#659)
cce05cc 
* Initialise chromap module

* Revert "Initialise chromap module"

This reverts commit 47c67ae.

* Remake chromap base files with new layout

* Copy chromap

* Copy index

* Add compression

* Update padding

* Update container

* Update chromap input test data

* Add chromap chromap tests

* Add padding

* Update comment

* update yaml file

* Remove TODOs

* Add fasta input to yaml

* Update YAML

* Remove comment, update container

* Remove comments

* Import Chromap index

* Update test.yml

* Fix read input

* Update test.yml

* Add bcftools/concat module. (nf-core#641)

* draft for bcftools modules [ci skip]

* initial test for bcftools concat

* Update the params for testing

* fix tests

* Accomodate code review [ci skip]

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>

* Update the meta file and open PR for review

* Update the keyword

* Update the tags for module [ci skip[

* add threads

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>

* add module for dragonflye (nf-core#633)

* add module for dragonflye

* fix tests for dragonflye

* Update test.yml

* Update meta.yml

* Update main.nf

* Update main.nf

* Update modules/dragonflye/meta.yml

Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>

* update typos. change quote from ' to ". (nf-core#652)

* Add bcftools/norm module (nf-core#655)

* Initial draft [ci skip]

* trigger first test

* update output file path

* Tests passing

* finishing touches for meta.yml and update checksum

* tweak checksum

* add threads to the module

* skip version info for matching test md5sum [ci skip]

* Add ref fasta and finalize the module

Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>

* Expansionhunter (nf-core#666)


Please enter the commit message for your changes. Lines starting

* adds expansionhunter module

Co-authored-by: Maxime U. Garcia <maxime.garcia@scilifelab.se>

* Update test.yml (nf-core#668)

* Specify in guidelines one should split CPUs when module has n > 1 tool (nf-core#660)

* Specify more guidelines on input channels

* Linting

* Updates based on code review

* Update README.md

* Fix broken sentence

* Describe CPU splitting

* Update README.md

Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>

* More CPU examples

Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>

* Add dsh-bio export-segments module (nf-core#631)

Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>

* update: `BWA/ALN` (nf-core#653)

* Specify more guidelines on input channels

* Linting

* Updates based on code review

* Update README.md

* Fix broken sentence

* Remove reads from output channel following module guidelines. Should do a .join() based on $meta, to reassociate.

Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>

* Update seqwish reported version to match bioconda version. (nf-core#678)

* Bbmap index (nf-core#683)

BBMap index module

* Initialise chromap module

* Revert "Initialise chromap module"

This reverts commit 47c67ae.

* Remove unnecessary files

* Remove unnecessary files

* Update modules/chromap/index/main.nf

Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>

* Update modules/chromap/index/main.nf

Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>

* Update modules/chromap/chromap/main.nf

Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>

* Update tests/modules/chromap/chromap/main.nf

Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>

* Update tests/modules/chromap/chromap/main.nf

Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>

* Update tests/modules/chromap/chromap/main.nf

Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>

* Update modules/chromap/index/main.nf

Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>

* Remove pytest_software.yml

* Apply suggestions from code review

Co-authored-by: Abhinav Sharma <abhi18av@users.noreply.github.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: Robert A. Petit III <robbie.petit@gmail.com>
Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>
Co-authored-by: JIANHONG OU <jianhong@users.noreply.github.com>
Co-authored-by: Anders Jemt <jemten@users.noreply.github.com>
Co-authored-by: Maxime U. Garcia <maxime.garcia@scilifelab.se>
Co-authored-by: Michael L Heuer <heuermh@acm.org>
Co-authored-by: Daniel Lundin <daniel.lundin@lnu.se>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikrikarddaniel @jfy133