Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Move most modules from local into nf-core #63

Closed
jpfeuffer opened this issue Oct 11, 2022 · 7 comments
Closed

Move most modules from local into nf-core #63

jpfeuffer opened this issue Oct 11, 2022 · 7 comments
Labels
enhancement Improvement for existing functionality

Comments

@jpfeuffer
Copy link
Collaborator

Description of feature

Especially the ones from the openms/subfolder. So they can be reused for other pipelines.
They should be mostly nf-core compatible already but might require some tests and minor adaptions.

@jpfeuffer jpfeuffer added the enhancement Improvement for existing functionality label Oct 11, 2022
@rolivella
Copy link

FYI I'm working on moving the IDFilter: nf-core/modules#2205

@jpfeuffer
Copy link
Collaborator Author

jpfeuffer commented Oct 11, 2022

That's great. Having the first example hopefully will help other contributors to help out.

@rolivella
Copy link

Yes! But I think is not intrinsically related to quantms pipeline. nf-core modules are not linked to this pipeline, are general modules that can be reused into any pipeline...

And It's going to take me some time, is quite complex! I'll not finish it today in the hackathon.

@jpfeuffer
Copy link
Collaborator Author

Yes true, the first step is to make nf-core modules (e.g., out of the ones in quantms), which is a "global" nf-core task. Then we can start replacing the local ones here with the global ones.

@jonasscheid
Copy link

FYI: https://nf-co.re/modules/openms_idfilter

@jonasscheid
Copy link

And I had the time to do some more (simple) modules during the last hackathon 🥳
https://github.com/nf-core/modules/tree/master/modules/nf-core/openms

@ypriverol
Copy link
Member

This is a major refactoring. I will close the issue for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants