Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong memory qualifier in postprocessgermlinecnvcalls #441

Open
Jakob37 opened this issue Nov 8, 2023 · 1 comment
Open

Wrong memory qualifier in postprocessgermlinecnvcalls #441

Jakob37 opened this issue Nov 8, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Jakob37
Copy link
Contributor

Jakob37 commented Nov 8, 2023

Description of the bug

In GATK4_POSTPROCESSGERMLINECNVCALLS, the memory is handled in megabytes, but assigned to the java process in gigabytes.

See: https://github.com/nf-core/raredisease/blob/master/modules/nf-core/gatk4/postprocessgermlinecnvcalls/main.nf

If for instance having access to 20GB, this would lead to the java being told to run with 20TB.

Key parts from the script block.

def avail_mem = 3072 <- Megabytes
if (!task.memory) {
    log.info '[GATK GermlineCNVCaller] Available memory not known - defaulting to 3GB. Specify process memory requirements to change this.'
} else {
    avail_mem = (task.memory.mega*0.8).intValue() <- Megabytes
}
"""
gatk --java-options "-Xmx${avail_mem}g" PostprocessGermlineCNVCalls \\ <- Assigned in gigabytes
    $calls_command \\
    $model_command \\
    $ploidy_command \\
    --output-genotyped-intervals ${prefix}_genotyped_intervals.vcf.gz \\
    --output-genotyped-segments ${prefix}_genotyped_segments.vcf.gz \\
    --output-denoised-copy-ratios ${prefix}_denoised.vcf.gz
"""

Command used and terminal output

No response

Relevant files

No response

System information

No response

@Jakob37 Jakob37 added the bug Something isn't working label Nov 8, 2023
@jemten
Copy link
Collaborator

jemten commented Nov 8, 2023

That's a lot of memory 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants