-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MultiQC version from 1.17 -> 1.19 #1159
Conversation
|
label 'process_single' | ||
|
||
// Requires `pyyaml` which does not have a dedicated container but is in the MultiQC container | ||
- conda "${moduleDir}/environment.yml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be simpler to update the central module and bump it here? The Kallisto modules have the environment yml too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely. But I thought I would just patch this for now because the plan is to remove this module altogether when moving to nf-test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can create a small follow up PR before the release bumping the module and re-installing if you like? I'll merge this for now so others can test the fix works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #1158