Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bam_markduplicates_picard subworkflow #1274

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Update bam_markduplicates_picard subworkflow #1274

merged 2 commits into from
Apr 5, 2024

Conversation

adamrtalbot
Copy link
Contributor

@adamrtalbot adamrtalbot commented Mar 22, 2024 •
edited
Loading

Bumps bam_markduplicates_picard which was raising a linting error.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@adamrtalbot adamrtalbot requested review from pinin4fjords and drpatelh and removed request for pinin4fjords March 22, 2024 11:42
maxulysse
maxulysse approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG?

@adamrtalbot
Copy link
Contributor Author

CHANGELOG?

Done!

@adamrtalbot adamrtalbot merged commit f6fa12c into nf-core:dev Apr 5, 2024
22 checks passed
@adamrtalbot adamrtalbot deleted the update_bam_markduplicates_picard branch April 5, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@drpatelh drpatelh Awaiting requested review from drpatelh

@pinin4fjords pinin4fjords Awaiting requested review from pinin4fjords

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamrtalbot @maxulysse