Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step to filter gtf for only chromosomes that exist in the fasta file #274

Merged
merged 24 commits into from
Sep 6, 2019

Conversation

olgabot
Copy link
Contributor

@olgabot olgabot commented Aug 30, 2019

This keeps gffread from complaining, and allows one to use the new dev pipeline with iGenomes files that may have extra features in the GTF.

Address #272

PR checklist

@olgabot
Copy link
Contributor Author

olgabot commented Aug 30, 2019

The -F flag in gffread adds all the GTF attributes to the fasta:

(sourmash-sbt2knn)
 Fri 30 Aug - 15:01  ~/ibm_lg/kmer-hashing/nextflow-intermediates/36/1916b1bf4672b99b68e879e8141dea 
  gffread -F -w transcripts.fa -g genome.fa genes_in_genome.gtf
(sourmash-sbt2knn)
 Fri 30 Aug - 15:03  ~/ibm_lg/kmer-hashing/nextflow-intermediates/36/1916b1bf4672b99b68e879e8141dea 
  gffread  -w transcripts_no_F.fa -g genome.fa genes_in_genome.gtf
head transcripts*
(sourmash-sbt2knn)
 Fri 30 Aug - 15:24  ~/ibm_lg/kmer-hashing/nextflow-intermediates/36/1916b1bf4672b99b68e879e8141dea 
  head transcripts*
==> transcripts.fa <==
>ENSPTRT00000074051 CDS=1-1158 gene_biotype=protein_coding gene_name=ENSPTRG00000041167 gene_source=ensembl gene_version=1 p_id=P6827 transcript_biotype=protein_coding transcript_source=ensembl transcript_version=1 tss_id=TSS28305 exon_version=1 protein_id=ENSPTRP00000060381 protein_version=1
ATGGCCTATTTAGGCCCATACCCTACGTCACTGCAGTCTCTGCAGATGAGGCTACTGCCTCACAACAGCC
TCCACAGGCACAGCTCCATCGTTACAATGGCCTCCTTAGACCCAGCTCCTGCCTCCCAGCCTTCTCTCCA
GGCCCTGAACTTTCTCAAGTCGACCTCACCAGGCCCAGTTCATGCTCCTTTGCAGCCTCTCCAGGCCCAG
CTCCTGCATCTTGGTGGCCCCTCCAGGCCCAGCCTCTGCCTCCCGTCGGCCTCTACAGTCCCAACATCTG
CCTCACAGCAGATTCTTCACGCCCAGCATCTGCCTCACTGTGGACCCCCCAAGCCAAGCTCCCAACCTTT
CAGCAGCTTCTACACACGCAGCTCCCACCTGCCAGTGGCCTCTTCAGGCCCATGGGGCTCATTCCTCACA
ACGGCCTTTCCAGGCCCAGTTTTTCCCTTCCGGCGTCCTCTCCGGGCCCAGAACCTCCTCAAGTCGGCCT
CTCCAGACCCACTTGCCCCCTCCGGGCGTCCTCTCTGGGCCCAGCTCTTCTTCCTGGTTGCGTCTCCAGG
CCCGACTCCTGCCTCTCAACAACCTCTTTGGACTCAGTGCCTACCCATCTCCTGGCGGCCTTGGTCGGCC

==> transcripts_no_F.fa <==
>ENSPTRT00000074051 CDS=1-1158
ATGGCCTATTTAGGCCCATACCCTACGTCACTGCAGTCTCTGCAGATGAGGCTACTGCCTCACAACAGCC
TCCACAGGCACAGCTCCATCGTTACAATGGCCTCCTTAGACCCAGCTCCTGCCTCCCAGCCTTCTCTCCA
GGCCCTGAACTTTCTCAAGTCGACCTCACCAGGCCCAGTTCATGCTCCTTTGCAGCCTCTCCAGGCCCAG
CTCCTGCATCTTGGTGGCCCCTCCAGGCCCAGCCTCTGCCTCCCGTCGGCCTCTACAGTCCCAACATCTG
CCTCACAGCAGATTCTTCACGCCCAGCATCTGCCTCACTGTGGACCCCCCAAGCCAAGCTCCCAACCTTT
CAGCAGCTTCTACACACGCAGCTCCCACCTGCCAGTGGCCTCTTCAGGCCCATGGGGCTCATTCCTCACA
ACGGCCTTTCCAGGCCCAGTTTTTCCCTTCCGGCGTCCTCTCCGGGCCCAGAACCTCCTCAAGTCGGCCT
CTCCAGACCCACTTGCCCCCTCCGGGCGTCCTCTCTGGGCCCAGCTCTTCTTCCTGGTTGCGTCTCCAGG
CCCGACTCCTGCCTCTCAACAACCTCTTTGGACTCAGTGCCTACCCATCTCCTGGCGGCCTTGGTCGGCC

@apeltzer
Copy link
Member

apeltzer commented Sep 4, 2019

Retriggered the tests after merging in the GFF one - we'll see soon if things work fine 👍

Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions / points :-)

main.nf Outdated Show resolved Hide resolved
main.nf Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
Co-Authored-By: Alexander Peltzer <apeltzer@users.noreply.github.com>
main.nf Outdated Show resolved Hide resolved
@olgabot
Copy link
Contributor Author

olgabot commented Sep 4, 2019

Yay passing finally!

@apeltzer
Copy link
Member

apeltzer commented Sep 5, 2019

Still something broken 👎

@olgabot
Copy link
Contributor Author

olgabot commented Sep 5, 2019

Aaah sorry about that. Will fix.

@olgabot
Copy link
Contributor Author

olgabot commented Sep 6, 2019

Okay ready when you are!

Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants