Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentieon DNAseq flow #1044

Merged
merged 226 commits into from
Jul 10, 2023
Merged

Sentieon DNAseq flow #1044

merged 226 commits into from
Jul 10, 2023

Conversation

asp8200
Copy link
Contributor

@asp8200 asp8200 commented May 26, 2023

Questions

  1. We have a test-config for sentieon-dedup, but not the other tests of sentieon; should we also have a test-config for, say, sentieon-haplotyper?
  2. We have the tools-options haplotypecalller and sentieon_haplotyper but the skip_tools-options haplotypecalller_filter and haplotyper_filter. Should haplotyper_filter perhaps be renamed to sentieon_haplotyper_filter?

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

asp8200 and others added 30 commits April 12, 2023 10:46
Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com>
Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com>
Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com>
add tests on sentieon branch
asp8200 and others added 9 commits July 2, 2023 14:54
Co-authored-by: Friederike Hanssen <Friederike.hanssen@qbic.uni-tuebingen.de>
Co-authored-by: Friederike Hanssen <Friederike.hanssen@qbic.uni-tuebingen.de>
Co-authored-by: Friederike Hanssen <Friederike.hanssen@qbic.uni-tuebingen.de>
Co-authored-by: Friederike Hanssen <Friederike.hanssen@qbic.uni-tuebingen.de>
…. Cosmetic changes in this new version of the script.
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@maxulysse
Copy link
Member

fixed the merge conflicts in nextflow.config due to merging the mutect2 PR

@asp8200
Copy link
Contributor Author

asp8200 commented Jul 6, 2023

@nf-core-bot fix linting

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
asp8200 and others added 5 commits July 6, 2023 12:08
Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com>
Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com>
@maxulysse maxulysse merged commit c2ff742 into dev Jul 10, 2023
51 checks passed
@maxulysse maxulysse deleted the sentieon branch September 18, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants