Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snpeff_db a string not a number #1143

Merged
merged 8 commits into from
Jul 6, 2023
Merged

snpeff_db a string not a number #1143

merged 8 commits into from
Jul 6, 2023

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Jul 5, 2023 •
edited
Loading

Thanks to @YeHW

@maxulysse maxulysse changed the title PREPARE: Release 2.6.1 snpeff_db a string not a number Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 851e11e

+| ✅ 152 tests passed       |+
#| ❔   9 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-07-06 17:55:24

@maxulysse
Copy link
Member Author

Lint failures will be fixed by #1140

FriederikeHanssen
FriederikeHanssen reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Did you test that this works when setting via the cli with just numbers? I remember there being issues with another parameter. Otherwise we might need to indicate somewhere that numbers need to be in quotes

@maxulysse
Copy link
Member Author

Hey! Did you test that this works when setting via the cli with just numbers? I remember there being issues with another parameter. Otherwise we might need to indicate somewhere that numbers need to be in quotes

Yeah, good point, I forgot about that, it fails on the command line, even with double quotes

@maxulysse
Copy link
Member Author

@nf-core-bot fix linting pretty please

@maxulysse maxulysse merged commit df3f252 into nf-core:dev Jul 6, 2023
19 checks passed
@maxulysse maxulysse deleted the snpeff branch July 6, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @FriederikeHanssen @nf-core-bot