Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markdup_java_options docs #167

Merged
merged 3 commits into from
Mar 30, 2020
Merged

markdup_java_options docs #167

merged 3 commits into from
Mar 30, 2020

Conversation

ggabernet
Copy link
Member

Should solve #166

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse
Copy link
Member

Wonderful, while you're at it, can you change the \--reads`to--input`:
https://github.com/nf-core/sarek/blob/38c7542a94c375aa2f6202ffa658e992e55892fa/docs/usage.md#--reads
I just noticed this error in the same markdown document.

@ggabernet
Copy link
Member Author

sure, just did that :)

maxulysse
maxulysse reviewed Mar 30, 2020
View reviewed changes
docs/usage.md Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Mar 30, 2020
View reviewed changes
docs/usage.md Outdated Show resolved Hide resolved
maxulysse
maxulysse approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for everything

@maxulysse maxulysse merged commit 07d63e4 into nf-core:dev Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@apeltzer apeltzer apeltzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ggabernet @maxulysse @apeltzer