Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD: Cache correctly identifies when it needs to be updated #985

Merged
merged 3 commits into from Mar 31, 2023
Merged

ADD: Cache correctly identifies when it needs to be updated #985

merged 3 commits into from Mar 31, 2023

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@maxulysse
Copy link
Member Author

cf nf-core/rnaseq#987

@github-actions
Copy link

github-actions bot commented Mar 31, 2023 •
edited

nf-core lint overall result: Passed ✅

Posted for pipeline commit 550ab32

+| ✅ 151 tests passed       |+
#| ❔   9 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-03-31 11:52:28

adamrtalbot
adamrtalbot approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@adamrtalbot adamrtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inspired.

@FriederikeHanssen FriederikeHanssen linked an issue Mar 31, 2023 that may be closed by this pull request
Fix caching for tests on custom runners #983
Closed
@maxulysse maxulysse merged commit fbc959a into nf-core:dev Mar 31, 2023
10 of 12 checks passed
@maxulysse maxulysse deleted the cache_hash branch March 31, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

@adamrtalbot adamrtalbot adamrtalbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix caching for tests on custom runners
3 participants
@maxulysse @FriederikeHanssen @adamrtalbot