Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for Release 2.0.0 #105

Merged
merged 204 commits into from Jun 17, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
204 commits
Select commit Hold shift + click to select a range
7822d1f
init dsl2 branch with cellranger modules and subworkflow
alexthiery1 Feb 18, 2021
ba4f5b1
add test data for cellranger subworkflow
alexthiery1 Mar 16, 2021
1c640c3
add config for module params and workflow testing
alexthiery1 Mar 16, 2021
a5f6e98
init cellranger subworkflow tests
alexthiery1 Mar 16, 2021
bbe48dd
edit fastq input into cellranger count
alexthiery1 Mar 16, 2021
e3eec29
init csv metadata module
alexthiery1 Mar 16, 2021
528977a
add versions and emit statements to modules
alexthiery1 Mar 19, 2021
552e79c
initial refactoring
KevinMenden Apr 14, 2021
9e8eea1
initial refactoring
KevinMenden Apr 14, 2021
4cf0282
started adding modules and building pipeline
KevinMenden Apr 14, 2021
107acff
added more modules
KevinMenden Apr 14, 2021
4793ddb
move star to local modules
KevinMenden Apr 14, 2021
a8f33ba
refactored into different workflows
KevinMenden Apr 15, 2021
cd0a61b
Merge remote-tracking branch 'origin/dev' into feat-dsl2
KevinMenden Apr 15, 2021
e125b91
Merge pull request #1 from KevinMenden/feat-dsl2
KevinMenden Apr 15, 2021
e0a5b07
added local alevin modules
KevinMenden Apr 15, 2021
271d07d
half-working alevin dsl2 version
KevinMenden Apr 15, 2021
404b1a9
more updates
KevinMenden Apr 16, 2021
2ff52d1
added multiqc, get software versions
KevinMenden Apr 19, 2021
4924218
added workflow groovy class
KevinMenden Apr 19, 2021
d14c7a7
working alevin version
KevinMenden Apr 19, 2021
d017531
removed 'type' parameter
KevinMenden Apr 19, 2021
92f045f
added whitelist to salmon_alevin
KevinMenden Apr 19, 2021
19cc78f
added completion and utils classes
KevinMenden Apr 19, 2021
fa8009f
updated schema; started with star
KevinMenden Apr 19, 2021
01bb273
working STARsolo pipeline
KevinMenden Apr 19, 2021
9c9c649
added multiqc to starsolo; fixed bug
KevinMenden Apr 19, 2021
5e86a46
Merge pull request #55 from KevinMenden/dev
KevinMenden Apr 19, 2021
3782c25
started with kb pipeline
KevinMenden Apr 20, 2021
7a71690
working kallistobustools version
KevinMenden Apr 20, 2021
8f84f58
added function to format the protocol
KevinMenden Apr 21, 2021
22bdf66
working tests for DSL2
KevinMenden Apr 26, 2021
c567ef3
updated schema
KevinMenden Apr 26, 2021
2029d8a
updated NfcoreSchema
KevinMenden Apr 26, 2021
482572b
updated patterns
KevinMenden Apr 26, 2021
8deffa6
updated schema again
KevinMenden Apr 26, 2021
17ea53b
feat: remove social preview image to use GitHub OpenGraph
maxulysse Apr 26, 2021
a1a5234
Merge pull request #57 from maxulysse/dev
ewels Apr 26, 2021
5534319
Apply suggestions from code review
KevinMenden Apr 27, 2021
7e0259e
Update lib/Workflow.groovy
KevinMenden Apr 27, 2021
52d902b
Merge pull request #56 from KevinMenden/dev
KevinMenden Apr 27, 2021
3facdb2
added checks
KevinMenden Apr 29, 2021
8d64aa5
Template update for nf-core/tools version 1.14
nf-core-bot May 11, 2021
c76bdb2
Update README.md
medulka Jun 18, 2021
f026d3f
Update README.md
medulka Jun 18, 2021
d1da6d6
Update README.md
medulka Jun 29, 2021
3f42e05
Update README.md
medulka Jun 29, 2021
032e0cb
Update README.md
medulka Jun 29, 2021
da06162
updated with new modules filepaths
KevinMenden Jul 12, 2021
ca17e12
Template update for nf-core/tools version 2.0
KevinMenden Jul 13, 2021
f2743e0
Template update for nf-core/tools version 2.0.1
nf-core-bot Jul 13, 2021
1f0cbe3
Template update for nf-core/tools version 2.1
nf-core-bot Jul 27, 2021
b52bad9
Merge branch 'dsl2' of https://github.com/nf-core/scrnaseq into dsl2
ggabernet Oct 22, 2021
a005015
Merge pull request #62 from KevinMenden/dev
ggabernet Oct 28, 2021
030eb8c
Merge branch 'TEMPLATE' of https://github.com/nf-core/scrnaseq into m…
ggabernet Oct 29, 2021
b34e121
fix groovy function errors
ggabernet Oct 29, 2021
1e767a6
update changelog
ggabernet Oct 29, 2021
b3e40fd
replace software for modules folder
ggabernet Oct 29, 2021
4a9928d
update nextflow schema groovy
ggabernet Oct 29, 2021
e8479a4
update nextflow schema
ggabernet Oct 29, 2021
7f04e01
update nf-core module versions
ggabernet Oct 29, 2021
6e55bdc
bump version
ggabernet Oct 29, 2021
f7baf7d
fix mkdown lint
ggabernet Oct 29, 2021
84ae5fa
Merge branch 'dsl2' of https://github.com/nf-core/scrnaseq into merge…
ggabernet Oct 29, 2021
288ec60
fix editorconfig lint
ggabernet Oct 29, 2021
4a1b964
fix gtf error
ggabernet Oct 29, 2021
dad29ac
Merge pull request #74 from ggabernet/merge-template-update
ggabernet Oct 29, 2021
4813f7d
Update modules/local/kallistobustools_count.nf
ggabernet Oct 29, 2021
51d4ff4
Update README.md
ggabernet Nov 2, 2021
ee073be
Template update for nf-core/tools version 2.2
nf-core-bot Dec 14, 2021
672864b
Merge pull request #73 from nf-core/dsl2
ggabernet Dec 15, 2021
5148fac
Fix kallistobus didn't run with multiple samples
grst Dec 30, 2021
c89c093
Update changelog
grst Dec 30, 2021
1816904
Fix same thing for alevin
grst Dec 30, 2021
7a784b6
Fix same issue for starsolo
grst Dec 30, 2021
a9ad586
Fix alevinqc
grst Dec 30, 2021
63890b7
Merge pull request #77 from grst/fix-kallistobus
apeltzer Jan 3, 2022
85b6485
Merge pull request #79 from grst/fix-alevinqc
apeltzer Jan 3, 2022
8f07c89
Merge branch 'dev' into nf-core-template-merge-2.2
grst Jan 3, 2022
6b57e5c
nf-core modules update --all
grst Jan 3, 2022
286ece1
Fix some nf-core lint
grst Jan 3, 2022
9ea336e
Temporarily re-add functions.nf for local modules
grst Jan 4, 2022
23ac0a4
Update pipeline to work with new nf-core modules
grst Jan 4, 2022
8a4d4b7
Update modules config to use new syntax
grst Jan 5, 2022
6b10991
Update local modules part 1
grst Jan 5, 2022
a1cab59
Update modules container directive
grst Jan 5, 2022
1222c9b
Remove addParams
grst Jan 5, 2022
cac6fea
Make process configuration conditional on aligner
grst Jan 5, 2022
c78b6d9
Switch to cellranger modules from nf-core/modules
grst Jan 5, 2022
fc5c35c
Update local modules to versions.yml syntax
grst Jan 5, 2022
b9a2700
Fix channel names due to updated modules
grst Jan 5, 2022
f5f18bc
Fix eclint
grst Jan 5, 2022
226cafb
Merge branch 'dev' into master
grst Jan 7, 2022
bbec4cf
Add Zenodo DOI
apeltzer Jan 12, 2022
21c56ac
Remove todos for samplesheet py
apeltzer Jan 12, 2022
931ee16
Drop it like its hot
apeltzer Jan 12, 2022
10221c0
Only lint warnings left
apeltzer Jan 12, 2022
ef3f494
Merge pull request #76 from nf-core/nf-core-template-merge-2.2
apeltzer Jan 12, 2022
f0f2963
WIP refactor workflows into subworkflows
grst Jan 17, 2022
392631a
Kallisto works again
grst Jan 20, 2022
ad2c106
Finish refactor salmon
grst Jan 22, 2022
b12610b
Finish refactoring starsolo
grst Jan 22, 2022
285a571
Fix eclint
grst Jan 22, 2022
0ab5cea
Unify multiqc
grst Jan 26, 2022
46e1ee6
Merge remote-tracking branch 'origin/dev' into medulka/master
grst Jan 26, 2022
be77265
Remove incorrect use of params instead of input channels
grst Jan 26, 2022
d197ede
Merge pull request #59 from medulka/master
grst Jan 26, 2022
c6da098
WIP cellranger workflow
grst Jan 26, 2022
796ad5b
Enable cellranger count
grst Jan 31, 2022
4f46e48
Make kb_workflow an enum
grst Jan 31, 2022
c8d04dc
Merge pull request #87 from grst/cellranger
grst Jan 31, 2022
00d0908
Fix cellranger input path
grst Feb 21, 2022
53149d5
Template update for nf-core/tools version 2.3
nf-core-bot Mar 15, 2022
fc6a77c
Template update for nf-core/tools version 2.3.1
nf-core-bot Mar 23, 2022
6aa1f86
Template update for nf-core/tools version 2.3.2
nf-core-bot Mar 24, 2022
b761136
transcriptome_fasta -> transcript_fasta
leipzig Mar 31, 2022
9df3564
Template update for nf-core/tools version 2.4
nf-core-bot May 16, 2022
562d0fa
Update check_samplesheet.py
fmalmeida May 23, 2022
09f7d87
Update check_samplesheet.py
fmalmeida May 23, 2022
e8b40a1
input check has a new parameter
fmalmeida May 23, 2022
b840c01
adding test_cellranger profile
fmalmeida May 24, 2022
b48778f
fixing schema for linting
fmalmeida May 24, 2022
fe6b82f
fixed unchanged templates with lint tool
fmalmeida May 24, 2022
e3f8108
Update ci.yml
fmalmeida May 27, 2022
b0cef8b
updating cellranger module to nf-core latest
fmalmeida May 30, 2022
180e627
Update check_samplesheet.py
fmalmeida May 30, 2022
910449c
Update kallistobustools_count.nf
fmalmeida May 30, 2022
d222ab4
Update scrnaseq.nf
fmalmeida May 30, 2022
3bc8b93
added parsing loop to handle replicates
fmalmeida May 31, 2022
60af471
added indentation to file
fmalmeida May 31, 2022
5998412
fixed cellranger test calling
fmalmeida May 31, 2022
6d4aada
Update check_samplesheet.py
fmalmeida May 31, 2022
3ed8ca3
updating cellranger module mkgtf to same version as count
fmalmeida May 31, 2022
84774fa
Delete .markdownlint.yml
fmalmeida May 31, 2022
e136763
updated to nf-core latest to have same docker image
fmalmeida May 31, 2022
7988823
Create .prettierrc.yml
fmalmeida May 31, 2022
f75a077
Update .prettierrc.yml
fmalmeida May 31, 2022
78674d9
Update nextflow.config
fmalmeida May 31, 2022
60aeed7
diminishing complexity on input channel generation
fmalmeida Jun 2, 2022
d8828bf
Update align_cellranger.nf
fmalmeida Jun 2, 2022
6d9caad
fixing and commenting channel generation
fmalmeida Jun 2, 2022
5955ac5
changing bad for loop
fmalmeida Jun 2, 2022
abf4b7e
Update align_cellranger.nf
fmalmeida Jun 2, 2022
5c2a21a
executed prettier on files
fmalmeida Jun 3, 2022
e44be22
Merge branch 'dev' into cellranger2
fmalmeida Jun 3, 2022
c8abde4
ran prettier after solving conflict
fmalmeida Jun 3, 2022
510a1b3
Revert "executed prettier on files" as it broke linting
fmalmeida Jun 3, 2022
ee5535b
added comment about input reads on relevant "local" modules
fmalmeida Jun 7, 2022
1879c6d
Merge pull request #90 from grst/cellranger2
apeltzer Jun 7, 2022
fb149e0
Merge branch 'dev' into nf-core-template-merge-2.4
fmalmeida Jun 7, 2022
b2385f9
params.txp2gene was wrongly set
fmalmeida Jun 8, 2022
1b313ca
Update nextflow_schema.json
fmalmeida Jun 8, 2022
f4ca2a6
fixed outdir default
fmalmeida Jun 8, 2022
3068f00
Update check_samplesheet.py
fmalmeida Jun 8, 2022
7a2c7fa
keep template command line definition
fmalmeida Jun 8, 2022
2e50060
Merge pull request #101 from nf-core/nf-core-template-merge-2.4
apeltzer Jun 8, 2022
9f8df74
Update README.md
apeltzer Jun 8, 2022
a664665
Fix lint & update all modules to latest version
apeltzer Jun 8, 2022
696113d
Merge pull request #102 from nf-core/fix-lint
apeltzer Jun 8, 2022
78786da
Update test_full.config
apeltzer Jun 8, 2022
fad5fb9
Update test_full.config
apeltzer Jun 8, 2022
aba50b2
adding missing example samplesheet
fmalmeida Jun 9, 2022
502d3f0
adding cellranger information
fmalmeida Jun 9, 2022
c1e6ef7
Update README.md
fmalmeida Jun 9, 2022
06b8aa7
update common command line
fmalmeida Jun 9, 2022
7d1dd50
removing duplicate entry and unused test profiles
fmalmeida Jun 9, 2022
4da3ffc
fixing example that was incorrect
fmalmeida Jun 9, 2022
ff6fed7
adding aligner options to docs
fmalmeida Jun 9, 2022
83a8735
rebuild json with nf-core schema build
fmalmeida Jun 9, 2022
4982093
Update conf/test_full.config
apeltzer Jun 9, 2022
79e089f
Update test_full.config
apeltzer Jun 9, 2022
199928b
Merge pull request #103 from nf-core/full-test
apeltzer Jun 9, 2022
d15c432
Apply suggestions from code review
apeltzer Jun 9, 2022
dd70a91
Fix prettier
apeltzer Jun 10, 2022
dabcdb1
Merge pull request #104 from nf-core/update-docs
apeltzer Jun 10, 2022
808aeeb
Fix whitespace
apeltzer Jun 10, 2022
562512a
Merge pull request #97 from truwl/dev
apeltzer Jun 10, 2022
e129d24
Update and fix last todos / lint erros and update multiqc module
apeltzer Jun 10, 2022
da58fbf
fix publishdir
ggabernet Jun 10, 2022
6851c16
Fix ec
apeltzer Jun 10, 2022
8200665
Version 2.0.0
apeltzer Jun 10, 2022
7cbf144
run all aligners on aws
ggabernet Jun 10, 2022
365e9ad
Fixed tests, now testing all
apeltzer Jun 10, 2022
f29b2fb
run all aligners on aws
ggabernet Jun 10, 2022
3e86cfe
fix publishdir
ggabernet Jun 10, 2022
302cf07
Merge branch 'dev' into dev
apeltzer Jun 10, 2022
ec3eca8
Merge pull request #106 from ggabernet/dev
apeltzer Jun 10, 2022
1a175e1
Update to CellRanger 7.0.0!
apeltzer Jun 10, 2022
2e77407
fix full test
ggabernet Jun 10, 2022
7ec5141
Merge pull request #107 from ggabernet/dev
apeltzer Jun 10, 2022
e53fd85
add default to outdir as it was in schema
fmalmeida Jun 10, 2022
4a6921d
back to null
fmalmeida Jun 10, 2022
2769109
remove outdir default line
fmalmeida Jun 10, 2022
1f87601
Update test_full.config
apeltzer Jun 10, 2022
2665d7c
Merge pull request #108 from nf-core/fmalmeida-outdir-default
apeltzer Jun 10, 2022
7f9d04a
Merge pull request #109 from nf-core/fix-full-tests
apeltzer Jun 10, 2022
0ac383c
Update test_full.config
apeltzer Jun 10, 2022
27fdb8b
Update test_full.config
apeltzer Jun 10, 2022
8766c4a
Update nextflow.config
fmalmeida Jun 16, 2022
ec6628f
update CI and full size test
ggabernet Jun 16, 2022
3698303
Merge pull request #112 from ggabernet/dev
ggabernet Jun 16, 2022
e4447fd
Merge pull request #111 from nf-core/removing-repeatitions
apeltzer Jun 16, 2022
c73f5cd
Fix for #60
apeltzer Jun 17, 2022
b2072d5
Merge pull request #113 from nf-core/fix-for-60
apeltzer Jun 17, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 24 additions & 0 deletions .editorconfig
@@ -0,0 +1,24 @@
root = true

[*]
charset = utf-8
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true
indent_size = 4
indent_style = space

[*.{md,yml,yaml,html,css,scss,js}]
indent_size = 2

# These files are edited and tested upstream in nf-core/modules
[/modules/nf-core/**]
charset = unset
end_of_line = unset
insert_final_newline = unset
trim_trailing_whitespace = unset
indent_style = unset
indent_size = unset

[/assets/email*]
indent_size = unset
2 changes: 2 additions & 0 deletions .gitattributes
@@ -1 +1,3 @@
*.config linguist-language=nextflow
modules/nf-core/** linguist-generated
subworkflows/nf-core/** linguist-generated
55 changes: 15 additions & 40 deletions .github/CONTRIBUTING.md
Expand Up @@ -15,11 +15,10 @@ Contributions to the code are even more welcome ;)

If you'd like to write some code for nf-core/scrnaseq, the standard workflow is as follows:

1. Check that there isn't already an issue about your idea in the [nf-core/scrnaseq issues](https://github.com/nf-core/scrnaseq/issues) to avoid duplicating work
* If there isn't one already, please create one so that others know you're working on this
1. Check that there isn't already an issue about your idea in the [nf-core/scrnaseq issues](https://github.com/nf-core/scrnaseq/issues) to avoid duplicating work. If there isn't one already, please create one so that others know you're working on this
2. [Fork](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) the [nf-core/scrnaseq repository](https://github.com/nf-core/scrnaseq) to your GitHub account
3. Make the necessary changes / additions within your forked repository following [Pipeline conventions](#pipeline-contribution-conventions)
4. Use `nf-core schema build .` and add any new parameters to the pipeline JSON schema (requires [nf-core tools](https://github.com/nf-core/tools) >= 1.10).
4. Use `nf-core schema build` and add any new parameters to the pipeline JSON schema (requires [nf-core tools](https://github.com/nf-core/tools) >= 1.10).
5. Submit a Pull Request against the `dev` branch and wait for the code to be reviewed and merged

If you're not used to this workflow with git, you can start with some [docs from GitHub](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests) or even their [excellent `git` resources](https://try.github.io/).
Expand Down Expand Up @@ -49,9 +48,9 @@ These tests are run both with the latest available version of `Nextflow` and als

:warning: Only in the unlikely and regretful event of a release happening with a bug.

* On your own fork, make a new branch `patch` based on `upstream/master`.
* Fix the bug, and bump version (X.Y.Z+1).
* A PR should be made on `master` from patch to directly this particular bug.
- On your own fork, make a new branch `patch` based on `upstream/master`.
- Fix the bug, and bump version (X.Y.Z+1).
- A PR should be made on `master` from patch to directly this particular bug.

## Getting help

Expand All @@ -68,22 +67,19 @@ If you wish to contribute a new step, please use the following coding standards:
1. Define the corresponding input channel into your new process from the expected previous process channel
2. Write the process block (see below).
3. Define the output channel if needed (see below).
4. Add any new flags/options to `nextflow.config` with a default (see below).
5. Add any new flags/options to `nextflow_schema.json` with help text (with `nf-core schema build .`).
6. Add any new flags/options to the help message (for integer/text parameters, print to help the corresponding `nextflow.config` parameter).
7. Add sanity checks for all relevant parameters.
8. Add any new software to the `scrape_software_versions.py` script in `bin/` and the version command to the `scrape_software_versions` process in `main.nf`.
9. Do local tests that the new code works properly and as expected.
10. Add a new test command in `.github/workflow/ci.yaml`.
11. If applicable add a [MultiQC](https://https://multiqc.info/) module.
12. Update MultiQC config `assets/multiqc_config.yaml` so relevant suffixes, name clean up, General Statistics Table column order, and module figures are in the right order.
13. Optional: Add any descriptions of MultiQC report sections and output files to `docs/output.md`.
4. Add any new parameters to `nextflow.config` with a default (see below).
5. Add any new parameters to `nextflow_schema.json` with help text (via the `nf-core schema build` tool).
6. Add sanity checks and validation for all relevant parameters.
7. Perform local tests to validate that the new code works as expected.
8. If applicable, add a new test command in `.github/workflow/ci.yml`.
9. Update MultiQC config `assets/multiqc_config.yml` so relevant suffixes, file name clean up and module plots are in the appropriate order. If applicable, add a [MultiQC](https://https://multiqc.info/) module.
10. Add a description of the output files and if relevant any appropriate images from the MultiQC report to `docs/output.md`.

### Default values

Parameters should be initialised / defined with default values in `nextflow.config` under the `params` scope.

Once there, use `nf-core schema build .` to add to `nextflow_schema.json`.
Once there, use `nf-core schema build` to add to `nextflow_schema.json`.

### Default processes resource requirements

Expand All @@ -95,34 +91,13 @@ The process resources can be passed on to the tool dynamically within the proces

Please use the following naming schemes, to make it easy to understand what is going where.

* initial process channel: `ch_output_from_<process>`
* intermediate and terminal channels: `ch_<previousprocess>_for_<nextprocess>`
- initial process channel: `ch_output_from_<process>`
- intermediate and terminal channels: `ch_<previousprocess>_for_<nextprocess>`

### Nextflow version bumping

If you are using a new feature from core Nextflow, you may bump the minimum required version of nextflow in the pipeline with: `nf-core bump-version --nextflow . [min-nf-version]`

### Software version reporting

If you add a new tool to the pipeline, please ensure you add the information of the tool to the `get_software_version` process.

Add to the script block of the process, something like the following:

```bash
<YOUR_TOOL> --version &> v_<YOUR_TOOL>.txt 2>&1 || true
```

or

```bash
<YOUR_TOOL> --help | head -n 1 &> v_<YOUR_TOOL>.txt 2>&1 || true
```

You then need to edit the script `bin/scrape_software_versions.py` to:

1. Add a Python regex for your tool's `--version` output (as in stored in the `v_<YOUR_TOOL>.txt` file), to ensure the version is reported as a `v` and the version number e.g. `v2.1.1`
2. Add a HTML entry to the `OrderedDict` for formatting in MultiQC.

### Images and figures

For overview images and other documents we follow the nf-core [style guidelines and examples](https://nf-co.re/developers/design_guidelines).
64 changes: 0 additions & 64 deletions .github/ISSUE_TEMPLATE/bug_report.md

This file was deleted.

50 changes: 50 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yml
@@ -0,0 +1,50 @@
name: Bug report
description: Report something that is broken or incorrect
labels: bug
body:
- type: markdown
attributes:
value: |
Before you post this issue, please check the documentation:

- [nf-core website: troubleshooting](https://nf-co.re/usage/troubleshooting)
- [nf-core/scrnaseq pipeline documentation](https://nf-co.re/scrnaseq/usage)

- type: textarea
id: description
attributes:
label: Description of the bug
description: A clear and concise description of what the bug is.
validations:
required: true

- type: textarea
id: command_used
attributes:
label: Command used and terminal output
description: Steps to reproduce the behaviour. Please paste the command you used to launch the pipeline and the output from your terminal.
render: console
placeholder: |
$ nextflow run ...

Some output where something broke

- type: textarea
id: files
attributes:
label: Relevant files
description: |
Please drag and drop the relevant files here. Create a `.zip` archive if the extension is not allowed.
Your verbose log file `.nextflow.log` is often useful _(this is a hidden file in the directory where you launched the pipeline)_ as well as custom Nextflow configuration files.

- type: textarea
id: system
attributes:
label: System information
description: |
* Nextflow version _(eg. 21.10.3)_
* Hardware _(eg. HPC, Desktop, Cloud)_
* Executor _(eg. slurm, local, awsbatch)_
* Container engine: _(e.g. Docker, Singularity, Conda, Podman, Shifter or Charliecloud)_
* OS _(eg. CentOS Linux, macOS, Linux Mint)_
* Version of nf-core/scrnaseq _(eg. 1.1, 1.5, 1.8.2)_
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/config.yml
@@ -1,4 +1,3 @@
blank_issues_enabled: false
contact_links:
- name: Join nf-core
url: https://nf-co.re/join
Expand Down
32 changes: 0 additions & 32 deletions .github/ISSUE_TEMPLATE/feature_request.md

This file was deleted.

11 changes: 11 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.yml
@@ -0,0 +1,11 @@
name: Feature request
description: Suggest an idea for the nf-core/scrnaseq pipeline
labels: enhancement
body:
- type: textarea
id: description
attributes:
label: Description of feature
description: Please describe your suggestion for a new feature. It might help to describe a problem or use case, plus any alternatives that you have considered.
validations:
required: true
5 changes: 2 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Expand Up @@ -15,11 +15,10 @@ Learn more about contributing: [CONTRIBUTING.md](https://github.com/nf-core/scrn

- [ ] This comment contains a description of changes (with reason).
- [ ] If you've fixed a bug or added code that should be tested, add tests!
- [ ] If you've added a new tool - add to the software_versions process and a regex to `scrape_software_versions.py`
- [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/scrnaseq/tree/master/.github/CONTRIBUTING.md)
- [ ] If necessary, also make a PR on the nf-core/scrnaseq _branch_ on the [nf-core/test-datasets](https://github.com/nf-core/test-datasets) repository.
- [ ] Make sure your code lints (`nf-core lint .`).
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker`).
- [ ] Make sure your code lints (`nf-core lint`).
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker --outdir <OUTDIR>`).
- [ ] Usage Documentation in `docs/usage.md` is updated.
- [ ] Output Documentation in `docs/output.md` is updated.
- [ ] `CHANGELOG.md` is updated.
Expand Down
12 changes: 0 additions & 12 deletions .github/markdownlint.yml

This file was deleted.

53 changes: 19 additions & 34 deletions .github/workflows/awsfulltest.yml
@@ -1,46 +1,31 @@
name: nf-core AWS full size tests
# This workflow is triggered on published releases.
# It can be additionally triggered manually with GitHub actions workflow dispatch.
# It can be additionally triggered manually with GitHub actions workflow dispatch button.
# It runs the -profile 'test_full' on AWS batch

on:
workflow_run:
workflows: ["nf-core Docker push (release)"]
types: [completed]
release:
types: [published]
workflow_dispatch:


env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
TOWER_ACCESS_TOKEN: ${{ secrets.AWS_TOWER_TOKEN }}
AWS_JOB_DEFINITION: ${{ secrets.AWS_JOB_DEFINITION }}
AWS_JOB_QUEUE: ${{ secrets.AWS_JOB_QUEUE }}
AWS_S3_BUCKET: ${{ secrets.AWS_S3_BUCKET }}


jobs:
run-awstest:
run-tower:
name: Run AWS full tests
if: github.repository == 'nf-core/scrnaseq'
runs-on: ubuntu-latest
strategy:
matrix:
aligner: ["alevin", "kallisto", "star", "cellranger"]
steps:
- name: Setup Miniconda
uses: conda-incubator/setup-miniconda@v2
- name: Launch workflow via tower
uses: nf-core/tower-action@v3
with:
auto-update-conda: true
python-version: 3.7
- name: Install awscli
run: conda install -c conda-forge awscli
- name: Start AWS batch job
# TODO nf-core: You can customise AWS full pipeline tests as required
# Add full size test data (but still relatively small datasets for few samples)
# on the `test_full.config` test runs with only one set of parameters
# Then specify `-profile test_full` instead of `-profile test` on the AWS batch command
run: |
aws batch submit-job \
--region eu-west-1 \
--job-name nf-core-scrnaseq \
--job-queue $AWS_JOB_QUEUE \
--job-definition $AWS_JOB_DEFINITION \
--container-overrides '{"command": ["nf-core/scrnaseq", "-r '"${GITHUB_SHA}"' -profile test --outdir s3://'"${AWS_S3_BUCKET}"'/scrnaseq/results-'"${GITHUB_SHA}"' -w s3://'"${AWS_S3_BUCKET}"'/scrnaseq/work-'"${GITHUB_SHA}"' -with-tower"], "environment": [{"name": "TOWER_ACCESS_TOKEN", "value": "'"$TOWER_ACCESS_TOKEN"'"}]}'
workspace_id: ${{ secrets.TOWER_WORKSPACE_ID }}
access_token: ${{ secrets.TOWER_ACCESS_TOKEN }}
compute_env: ${{ secrets.TOWER_COMPUTE_ENV }}
workdir: s3://${{ secrets.AWS_S3_BUCKET }}/work/scrnaseq/work-${{ github.sha }}
parameters: |
{
"outdir": "s3://${{ secrets.AWS_S3_BUCKET }}/scrnaseq/results-${{ github.sha }}/aligner_${{ matrix.aligner }}",
"aligner": "${{ matrix.aligner }}"
}
profiles: test_full,aws_tower