Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 196 #197

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Fix 196 #197

merged 2 commits into from
Feb 13, 2023

Conversation

apeltzer
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/scrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@apeltzer apeltzer mentioned this pull request Feb 13, 2023
Closed
@github-actions
Copy link

github-actions bot commented Feb 13, 2023 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit 5614f0a

+| ✅ 149 tests passed       |+
-| ❌   9 tests failed       |-

❌ Test failures:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-02-13 07:47:14

@apeltzer apeltzer merged commit 50d3098 into dev Feb 13, 2023
@apeltzer apeltzer deleted the fix-196 branch February 13, 2023 09:43
@nictru nictru mentioned this pull request May 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmalmeida fmalmeida fmalmeida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@apeltzer @fmalmeida