Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cellrangerarc snippet back #321

Merged
merged 1 commit into from Apr 30, 2024
Merged

Add cellrangerarc snippet back #321

merged 1 commit into from Apr 30, 2024

Conversation

fmalmeida
Copy link
Contributor

Relates do discussion here in PR #318 .

@fmalmeida fmalmeida requested a review from grst April 30, 2024 10:29
@fmalmeida fmalmeida changed the base branch from master to dev April 30, 2024 10:29
@github-actions GitHub Actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @fmalmeida,

It looks like this pull-request is has been made against the nf-core/scrnaseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/scrnaseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@fmalmeida fmalmeida requested a review from apeltzer April 30, 2024 10:29
@fmalmeida fmalmeida self-assigned this Apr 30, 2024
@fmalmeida fmalmeida mentioned this pull request Apr 30, 2024
Merged
12 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 900606f

+| ✅ 170 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 2.6.0
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-04-30 10:30:53

@grst grst merged commit 7be5e57 into dev Apr 30, 2024
11 of 13 checks passed
@grst grst deleted the add-cellrangerarc-snippet-back branch April 30, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grst grst grst approved these changes

@apeltzer apeltzer Awaiting requested review from apeltzer

Assignees

@fmalmeida fmalmeida

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fmalmeida @grst