Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kallistobus didn't run with multiple samples #77

Merged
merged 4 commits into from Jan 3, 2022

Conversation

grst
Copy link
Member

@grst grst commented Dec 30, 2021

Du to a lacking collect() on the index, kallisto only ran on a single sample even when multiple ones were specified in the samplesheet.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/scrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@grst
Copy link
Member Author

grst commented Dec 30, 2021

nf-core linting failure is not my fault (I think) and needs to be addressed separately in #76

@apeltzer
Copy link
Member

apeltzer commented Jan 3, 2022

Thank you Gregor!

@apeltzer apeltzer merged commit 63890b7 into nf-core:dev Jan 3, 2022
@susheelbhanu
Copy link

Hi,

I'm running the -r dev version of scrnaseq with multiple samples and it does not yet run kallisto or bustools. Has this been pushed to the dev branch?

Here's what my processes looks like:

WARN: Access to undefined parameter `fasta` -- Initialise it to a default value eg. `params.fasta = some_value`
[-        ] process > NFCORE_SCRNASEQ:SCRNASEQ:SCRNASEQ_ALEVIN:INPUT_CHECK:SAMPLESHEET_CHECK [  0%] 0 of 1
executor >  local (3)
executor >  local (3)
executor >  local (4)
executor >  local (4)
executor >  local (4)
executor >  local (5)
[41/8f3c1c] process > NFCORE_SCRNASEQ:SCRNASEQ:SCRNASEQ_ALEVIN:INPUT_CHECK:SAMPLESHEET_CHECK (samplesheet.csv) [100%] 1 of 1 ✔
[3f/de24d4] process > NFCORE_SCRNASEQ:SCRNASEQ:SCRNASEQ_ALEVIN:GUNZIP (10x_V3_barcode_whitelist.txt.gz)        [100%] 1 of 1 ✔
[a3/d61340] process > NFCORE_SCRNASEQ:SCRNASEQ:SCRNASEQ_ALEVIN:GFFREAD_TRANSCRIPTOME (GRCh38.p13.fa)           [100%] 1 of 1 ✔
[c4/7976b9] process > NFCORE_SCRNASEQ:SCRNASEQ:SCRNASEQ_ALEVIN:SALMON_INDEX (GRCh38.p13.fa.transcriptome.fa)   [  0%] 0 of 1
[b7/3e8fb7] process > NFCORE_SCRNASEQ:SCRNASEQ:SCRNASEQ_ALEVIN:GFFREAD_TXP2GENE (GRCh38.p13.annotation.gtf)    [100%] 1 of 1 ✔
[-        ] process > NFCORE_SCRNASEQ:SCRNASEQ:SCRNASEQ_ALEVIN:SALMON_ALEVIN                                   -
[-        ] process > NFCORE_SCRNASEQ:SCRNASEQ:SCRNASEQ_ALEVIN:ALEVINQC                                        -
[-        ] process > NFCORE_SCRNASEQ:SCRNASEQ:SCRNASEQ_ALEVIN:GET_SOFTWARE_VERSIONS                           -
[-        ] process > NFCORE_SCRNASEQ:SCRNASEQ:SCRNASEQ_ALEVIN:MULTIQC                                         -

Thank you,
Susheel

@susheelbhanu
Copy link

Please ignore the above. Just saw that i needed to add the --aligner kallisto flag. 🤦🏽

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants