Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transcriptome_fasta -> transcript_fasta #97

Merged
merged 1 commit into from Jun 10, 2022
Merged

transcriptome_fasta -> transcript_fasta #97

merged 1 commit into from Jun 10, 2022

Conversation

leipzig
Copy link
Contributor

@leipzig leipzig commented Mar 31, 2022

this fixes the inconsistent variable name transcriptome_fasta to transcript_fasta in the alevin module

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure the test suite passes (nextflow run . -profile test,docker).

@grst
Copy link
Member

grst commented Mar 31, 2022

Thanks! Is alevin the only workflow with this problem?

@grst
Copy link
Member

grst commented Mar 31, 2022

The tests failing is not your fault, it's because the test data samplesheet is already updated, the pipeline code not yet.

@apeltzer apeltzer merged commit 562512a into nf-core:dev Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer apeltzer approved these changes

@grst grst grst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leipzig @grst @apeltzer